Skip to content

enable to transition to SEGMENT_ROUTING_NODE when pathd is disabled - #10350

Merged
idryzhov merged 1 commit into
FRRouting:masterfrom
Drumato:fix-zebra-srv6-segment-routing-block
Jan 17, 2022
Merged

enable to transition to SEGMENT_ROUTING_NODE when pathd is disabled#10350
idryzhov merged 1 commit into
FRRouting:masterfrom
Drumato:fix-zebra-srv6-segment-routing-block

Conversation

@Drumato

@Drumato Drumato commented Jan 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Currently segment_routing_cmd is not installed but defined when FRR configured with --disable-pathd.
but SEGMENT_ROUTING_NODE is used Zebra SRv6 Manager too.
so this patch enables SEGMENT_ROUTING_NODE when FRR configured with --disable-pathd.

In Cisco's CLI, SRV6_NODE is directly installed on CONFIG_NODE .
I'll contribute to make SRv6 Manager to follow Cisco's CLI as another PR after this PR will be merged.
reference: https://www.cisco.com/c/en/us/td/docs/routers/asr9000/software/asr9k-r7-3/segment-routing/configuration/guide/b-segment-routing-cg-asr9000-73x/m-configure-srv6-usid.html?referring_site=RE&pos=1&page=https://www.cisco.com/c/en/us/td/docs/routers/asr9000/software/asr9k-r6-6/segment-routing/configuration/guide/b-segment-routing-cg-asr9000-66x/b-segment-routing-cg-asr9000-66x_chapter_011.html

AS-IS

if I configure FRR with --disable-pathd, srv6_locator topotest fails.

root:~/frr/tests/topotests/srv6_locator# git show HEAD
commit 2aa2e5932076a1f8dd641056a2f27cd7bd36f4af (HEAD -> master, upstream/master)
Merge: bf2209ec0 c1984955b
Author: David Lamparter <equinox@opensourcerouting.org>
Date:   Sat Jan 15 17:23:55 2022 +0100

    Merge pull request #10343 from taspelund/fix_receivedRoutes_string

root:~/frr.drumato/tests/topotests/srv6_locator# ./test_srv6_locator.py --topology-only
============================================================================== test session starts ===============================================================================
platform linux -- Python 3.8.0, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
rootdir: /root/frr.drumato/tests/topotests, configfile: pytest.ini
collected 1 item

test_srv6_locator.py
--- Micronet CLI Starting ---


unet> r1 sh daemons
 zebra bgpd sharpd staticd

unet> sh r1 vtysh -c "conf te" -c "segment-routing"
% Unknown command: segment-routing

TO-BE

srv6_locator topotest will pass when FRR is configured with --disable-pathd.

root:~/frr/tests/topotests/srv6_locator# git show HEAD
commit a120c63f142ccd6e96b3ac7876030db29396b5a8 (HEAD -> fix-zebra-srv6-segment-routing-block)
Author: Yamato Sugawara <yamato.sugawara@linecorp.com>
Date:   Sun Jan 16 04:08:47 2022 +0000

    zebra: fix `segment-routing` command not found error with `--disable-pathd`

    Signed-off-by: Yamato Sugawara <yamato.sugawara@linecorp.com>

diff --git a/vtysh/vtysh.c b/vtysh/vtysh.c
index c56b72fcb..32088344d 100644
--- a/vtysh/vtysh.c
+++ b/vtysh/vtysh.c
@@ -4284,6 +4284,7 @@ void vtysh_init_vty(void)
        install_element(SEGMENT_ROUTING_NODE, &vtysh_quit_sr_cmd);
        install_element(SEGMENT_ROUTING_NODE, &vtysh_end_all_cmd);

+       install_element(CONFIG_NODE, &segment_routing_cmd);
 #if defined(HAVE_PATHD)
        install_node(&sr_traffic_eng_node);
        install_node(&srte_segment_list_node);
@@ -4305,7 +4306,6 @@ void vtysh_init_vty(void)
        install_element(SR_POLICY_NODE, &vtysh_end_all_cmd);
        install_element(SR_CANDIDATE_DYN_NODE, &vtysh_end_all_cmd);

-       install_element(CONFIG_NODE, &segment_routing_cmd);
        install_element(SEGMENT_ROUTING_NODE, &sr_traffic_eng_cmd);
        install_element(SR_TRAFFIC_ENG_NODE, &srte_segment_list_cmd);
        install_element(SR_TRAFFIC_ENG_NODE, &srte_policy_cmd);
root:~/frr/tests/topotests/srv6_locator# ./test_srv6_locator.py --topology-only
============================================================================== test session starts ===============================================================================
platform linux -- Python 3.8.0, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
rootdir: /root/frr.drumato/tests/topotests, configfile: pytest.ini
collected 1 item

test_srv6_locator.py
--- Micronet CLI Starting ---


unet> r1 sh daemons
 zebra bgpd sharpd staticd

unet> sh r1 vtysh -c "conf t" -c "segment-routing"

Signed-off-by: Yamato Sugawara yamato.sugawara@linecorp.com

@NetDEF-CI

NetDEF-CI commented Jan 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator
Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2726/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Debian 9 deb pkg check: Failed (click for details) Debian 9 deb pkg check: No useful log found
Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-2726/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2726/artifact/TOPO9DEB10AMD64/ErrorLog/log_topotests.txt

Ubuntu 20.04 deb pkg check: Failed (click for details) Ubuntu 20.04 deb pkg check: No useful log found
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 arm8 part 5
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 6
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 5
  • Static analyzer (clang)
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 2
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 6
  • Ubuntu 18.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 1
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 i386 part 9
  • Addresssanitizer topotests part 4
  • Topotests debian 10 amd64 part 5
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 i386 part 7
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 5
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 16.04 deb pkg check
  • Debian 10 deb pkg check
  • Topotests debian 10 amd64 part 8
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 9
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 7
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 3
  • Fedora 29 rpm pkg check
  • Addresssanitizer topotests part 9
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 i386 part 3

@Drumato

Drumato commented Jan 16, 2022

Copy link
Copy Markdown
Contributor Author

ci:rerun

1 similar comment
@Drumato

Drumato commented Jan 16, 2022

Copy link
Copy Markdown
Contributor Author

ci:rerun

@NetDEF-CI

NetDEF-CI commented Jan 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator
Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2730/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: No useful log found
Successful on other platforms/tests
  • Debian 10 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 16.04 arm7 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 20.04 amd64 build
  • NetBSD 9 amd64 build
  • OpenBSD 7 amd64 build
  • CentOS 7 amd64 build
  • Debian 9 amd64 build
  • Redhat 8 amd64 build
  • Ubuntu 18.04 ppc64le build
  • FreeBSD 12 amd64 build
  • Fedora 29 amd64 build
  • Debian 11 amd64 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 18.04 arm8 build

@Drumato

Drumato commented Jan 16, 2022

Copy link
Copy Markdown
Contributor Author

ci:rerun

@NetDEF-CI

NetDEF-CI commented Jan 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator
Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2729/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

idryzhov
idryzhov requested changes Jan 16, 2022
View reviewed changes

@idryzhov idryzhov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is right, just one request to comply with the common style.

Comment thread vtysh/vtysh.c Outdated
@idryzhov

idryzhov commented Jan 16, 2022

Copy link
Copy Markdown
Contributor

@Mergifyio backport stable/8.1

@mergify

mergify Bot commented Jan 16, 2022

Copy link
Copy Markdown

backport stable/8.1

🟠 Waiting for conditions to match

Details
  • merged [:pushpin: backport requirement]

@NetDEF-CI

NetDEF-CI commented Jan 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator
Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2731/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Ubuntu 16.04 deb pkg check: Failed (click for details) Ubuntu 16.04 deb pkg check: No useful log found
Successful on other platforms/tests
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 arm8 part 5
  • Fedora 29 rpm pkg check
  • CentOS 7 rpm pkg check
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 2
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 0
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 i386 part 0
  • Ubuntu 18.04 deb pkg check
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests debian 10 amd64 part 6
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests debian 10 amd64 part 5
  • Topotests debian 10 amd64 part 9
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests debian 10 amd64 part 4
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 arm8 part 3
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • Addresssanitizer topotests part 2
  • Ubuntu 20.04 deb pkg check
  • IPv6 protocols on Ubuntu 18.04
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 5
  • Debian 10 deb pkg check
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 amd64 part 9

@Drumato
zebra: fix segment-routing command not found error with `--disable-…
1b3aea9 
…pathd`

Signed-off-by: Yamato Sugawara <yamato.sugawara@linecorp.com>
@Drumato
Drumato force-pushed the fix-zebra-srv6-segment-routing-block branch from a120c63 to 1b3aea9 Compare January 16, 2022 12:46
@NetDEF-CI

NetDEF-CI commented Jan 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator
Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2738/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: No useful log found
Successful on other platforms/tests
  • Ubuntu 16.04 arm8 build
  • Ubuntu 18.04 amd64 build
  • Debian 11 amd64 build
  • Ubuntu 18.04 i386 build
  • NetBSD 9 amd64 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 16.04 amd64 build
  • CentOS 7 amd64 build
  • Ubuntu 16.04 i386 build
  • FreeBSD 12 amd64 build
  • Fedora 29 amd64 build
  • Ubuntu 20.04 amd64 build
  • OpenBSD 7 amd64 build
  • Ubuntu 18.04 arm8 build
  • Debian 9 amd64 build
  • Redhat 8 amd64 build
  • Debian 10 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 16.04 arm7 build

@idryzhov

idryzhov commented Jan 16, 2022

Copy link
Copy Markdown
Contributor

ci:rerun

@NetDEF-CI

NetDEF-CI commented Jan 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator
Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2739/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: No useful log found
Successful on other platforms/tests
  • Ubuntu 16.04 arm8 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 16.04 amd64 build
  • CentOS 7 amd64 build
  • Ubuntu 18.04 arm7 build
  • NetBSD 9 amd64 build
  • Debian 11 amd64 build
  • FreeBSD 12 amd64 build
  • OpenBSD 7 amd64 build
  • Redhat 8 amd64 build
  • Fedora 29 amd64 build
  • Ubuntu 18.04 arm8 build
  • Debian 9 amd64 build
  • Debian 10 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 16.04 arm7 build

@idryzhov

idryzhov commented Jan 16, 2022

Copy link
Copy Markdown
Contributor

ci:rerun

@NetDEF-CI

NetDEF-CI commented Jan 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator
Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2738/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

CentOS 7 rpm pkg check: Failed (click for details) CentOS 7 rpm pkg check: No useful log found
Debian 9 deb pkg check: Failed (click for details) Debian 9 deb pkg check: No useful log found
Ubuntu 16.04 deb pkg check: Failed (click for details) Ubuntu 16.04 deb pkg check: No useful log found
Ubuntu 20.04 deb pkg check: Failed (click for details) Ubuntu 20.04 deb pkg check: No useful log found
Debian 10 deb pkg check: Failed (click for details) Debian 10 deb pkg check: No useful log found
Successful on other platforms/tests
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 5
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 i386 part 0
  • Addresssanitizer topotests part 3
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 amd64 part 0
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests debian 10 amd64 part 5
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Ubuntu 18.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 6
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 8
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests debian 10 amd64 part 3
  • IPv6 protocols on Ubuntu 18.04
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 i386 part 6
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 arm8 part 0
  • IPv4 protocols on Ubuntu 18.04
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 5

@NetDEF-CI

NetDEF-CI commented Jan 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator
Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2739/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Ubuntu 20.04 deb pkg check: Failed (click for details) Ubuntu 20.04 deb pkg check: No useful log found
Successful on other platforms/tests
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests debian 10 amd64 part 1
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 amd64 part 4
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests debian 10 amd64 part 5
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests debian 10 amd64 part 7
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 8
  • Ubuntu 18.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 6
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 5
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 4
  • Topotests debian 10 amd64 part 3
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 8
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 3
  • Static analyzer (clang)
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 2
  • Addresssanitizer topotests part 9
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 0
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 amd64 part 5
  • Debian 10 deb pkg check

@NetDEF-CI

NetDEF-CI commented Jan 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator
Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2741/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Ubuntu 18.04 deb pkg check: Failed (click for details) Ubuntu 18.04 deb pkg check: No useful log found
Successful on other platforms/tests
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests debian 10 amd64 part 1
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 i386 part 0
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 4
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 0
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests debian 10 amd64 part 7
  • Topotests debian 10 amd64 part 5
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 8
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 5
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests debian 10 amd64 part 8
  • IPv6 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 9
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 2
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests debian 10 amd64 part 0
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 i386 part 6
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 8
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 amd64 part 5
  • Ubuntu 20.04 deb pkg check
  • Debian 10 deb pkg check

@idryzhov

idryzhov commented Jan 16, 2022

Copy link
Copy Markdown
Contributor

ci:rerun

@NetDEF-CI

NetDEF-CI commented Jan 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator
Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2743/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 i386 build: Failed (click for details) Ubuntu 18.04 i386 build: No useful log found
Successful on other platforms/tests
  • NetBSD 9 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 arm7 build
  • Fedora 29 amd64 build
  • Debian 11 amd64 build
  • Ubuntu 18.04 arm8 build
  • Ubuntu 16.04 i386 build
  • OpenBSD 7 amd64 build
  • Redhat 8 amd64 build
  • Debian 10 amd64 build
  • Ubuntu 16.04 arm7 build
  • CentOS 7 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 18.04 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 16.04 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 20.04 amd64 build

@Drumato

Drumato commented Jan 16, 2022

Copy link
Copy Markdown
Contributor Author

ci:rerun

@NetDEF-CI

NetDEF-CI commented Jan 16, 2022

Copy link
Copy Markdown
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2747/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@Drumato
Drumato requested a review from idryzhov January 17, 2022 00:49
@Drumato

Drumato commented Jan 17, 2022

Copy link
Copy Markdown
Contributor Author

@idryzhov CI passed! thanks to retry many times and give an approval!

@idryzhov
idryzhov merged commit 1f325f8 into FRRouting:master Jan 17, 2022
@mergify mergify Bot mentioned this pull request Jan 17, 2022
Merged
@mergify

mergify Bot commented Jan 17, 2022

Copy link
Copy Markdown

backport stable/8.1

✅ Backports have been created

Details

ton31337 added a commit that referenced this pull request Jan 17, 2022
@ton31337
Merge pull request #10354 from FRRouting/mergify/bp/stable/8.1/pr-10350
4757da7 
enable to transition to `SEGMENT_ROUTING_NODE` when pathd is disabled (backport #10350)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@idryzhov idryzhov Awaiting requested review from idryzhov

Assignees

No one assigned

Labels

bugfix zebra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Drumato @NetDEF-CI @idryzhov