Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Flowspec overflow issue #12884

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Conversation

donaldsharp
Copy link
Member

According to the flowspec RFC 8955 a flowspec nlri is <length, > Specifying 0 as a length makes BGP get all warm on the inside. Which in this case is not a good thing at all. Prevent warmth, stay cold on the inside.

Reported-by: Iggy Frankovic iggyfran@amazon.com

According to the flowspec RFC 8955 a flowspec nlri is <length, <nlri data>>
Specifying 0 as a length makes BGP get all warm on the inside.  Which
in this case is not a good thing at all.  Prevent warmth, stay cold
on the inside.

Reported-by: Iggy Frankovic <iggyfran@amazon.com>
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
@donaldsharp
Copy link
Member Author

@Mergifyio backport dev/8.5 stable/8.4 stable/8.3 stable/8.2 stable/8.1

@mergify
Copy link

mergify bot commented Feb 23, 2023

backport dev/8.5 stable/8.4 stable/8.3 stable/8.2 stable/8.1

✅ Backports have been created

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9871/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@ton31337 ton31337 added this to the 8.5 milestone Feb 23, 2023
@choppsv1 choppsv1 merged commit b1867d4 into FRRouting:master Feb 24, 2023
ton31337 added a commit that referenced this pull request Feb 24, 2023
ton31337 added a commit that referenced this pull request Feb 24, 2023
donaldsharp added a commit that referenced this pull request Feb 24, 2023
donaldsharp added a commit that referenced this pull request Feb 24, 2023
donaldsharp added a commit that referenced this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants