Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: Fix use beyond end of stream of labeled unicast parsing #12951

Merged
merged 1 commit into from Mar 5, 2023
Merged

bgpd: Fix use beyond end of stream of labeled unicast parsing #12951

merged 1 commit into from Mar 5, 2023

Conversation

donaldsharp
Copy link
Member

Fixes a couple crashes associated with attempting to read beyond the end of the stream.

Reported-by: Iggy Frankovic iggyfran@amazon.com

@donaldsharp
bgpd: Fix use beyond end of stream of labeled unicast parsing
7404a91 
Fixes a couple crashes associated with attempting to read
beyond the end of the stream.

Reported-by: Iggy Frankovic <iggyfran@amazon.com>
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
@frrbot frrbot bot added the bgp label Mar 4, 2023
@donaldsharp
Copy link
Member Author

@Mergifyio backport stable/8.5 stable/8.4 stable/8.3 stable/8.2 stable/8.1 stable/8.0

@mergify
Copy link

mergify bot commented Mar 4, 2023 •
edited

backport stable/8.5 stable/8.4 stable/8.3 stable/8.2 stable/8.1 stable/8.0

❌ No backport have been created

  • Backport to branch stable/8.5 failed

GitHub error: Branch not found

  • Backport to branch stable/8.4 in progress
  • Backport to branch stable/8.3 in progress
  • Backport to branch stable/8.2 in progress
  • Backport to branch stable/8.1 in progress
  • Backport to branch stable/8.0 in progress

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10043/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

ton31337
ton31337 reviewed Mar 4, 2023
View reviewed changes
bgpd/bgp_label.c
EC_BGP_UPDATE_RCV,
"%s [Error] Update packet error (wrong label length 0)",
peer->host);
bgp_notify_send(peer, BGP_NOTIFY_UPDATE_ERR,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to send a notification because it's handled in bgp_update_receive() already.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whole function is completely inconsistent :(

@ton31337 ton31337 merged commit e618cc7 into FRRouting:master Mar 5, 2023
@ton31337
Copy link
Member

ton31337 commented Mar 5, 2023

@Mergifyio backport dev/8.5 stable/8.4 stable/8.3 stable/8.2 stable/8.1 stable/8.0

@mergify
Copy link

mergify bot commented Mar 5, 2023 •
edited

backport dev/8.5 stable/8.4 stable/8.3 stable/8.2 stable/8.1 stable/8.0

✅ Backports have been created

@mergify mergify bot mentioned this pull request Mar 5, 2023
Merged
ton31337 added a commit that referenced this pull request Mar 6, 2023
@ton31337
Merge pull request #12956 from FRRouting/mergify/bp/dev/8.5/pr-12951
9f31d57 
bgpd: Fix use beyond end of stream of labeled unicast parsing (backport #12951)
@eqvinox
Copy link
Contributor

eqvinox commented May 5, 2024

@Mergifyio backport stable/8.4

@mergify Mergify
Copy link

mergify bot commented May 5, 2024 •
edited

backport stable/8.4

✅ Backports have been created

@mergify mergify bot mentioned this pull request May 5, 2024
Merged
eqvinox added a commit that referenced this pull request May 5, 2024
@eqvinox
Merge pull request #15926 from FRRouting/mergify/bp/stable/8.4/pr-12951
4bba120 
Fix use beyond end of stream of labeled unicast parsing (backport #12951)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ton31337 ton31337 ton31337 left review comments

Assignees
No one assigned
Labels
backport bgp master size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@donaldsharp @NetDEF-CI @ton31337 @eqvinox