Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Don't read the first byte of ORF header if we are ahead of stream #14245

Conversation

ton31337
Copy link
Member

Reported-by: Iggy Frankovic iggyfran@amazon.com

Reported-by: Iggy Frankovic iggyfran@amazon.com
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
@frrbot frrbot bot added the bgp label Aug 21, 2023
@ton31337
Copy link
Member Author

@Mergifyio backport stable/9.0 stable/8.5

@mergify
Copy link

mergify bot commented Aug 21, 2023

backport stable/9.0 stable/8.5

✅ Backports have been created

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Aug 21, 2023

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13685/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: No useful log found
Successful on other platforms/tests
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 18.04 arm8 build
  • Ubuntu 18.04 arm7 build
  • Debian 11 amd64 build
  • Redhat 8 amd64 build
  • Debian 10 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 22.04 amd64 build
  • Ubuntu 20.04 amd64 build
  • Debian 9 amd64 build
  • CentOS 7 amd64 build
  • Redhat 9 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 18.04 amd64 build

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13685/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@donaldsharp donaldsharp merged commit c2b0d6a into FRRouting:master Aug 21, 2023
7 checks passed
@ton31337 ton31337 deleted the fix/check_if_the_first_byte_is_not_null_orf branch August 21, 2023 13:53
donaldsharp added a commit that referenced this pull request Aug 21, 2023
bgpd: Don't read the first byte of ORF header if we are ahead of stream (backport #14245)
donaldsharp added a commit that referenced this pull request Aug 21, 2023
bgpd: Don't read the first byte of ORF header if we are ahead of stream (backport #14245)
@eqvinox
Copy link
Contributor

eqvinox commented May 5, 2024

@Mergifyio backport stable/8.4

Copy link

mergify bot commented May 5, 2024

backport stable/8.4

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants