New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: add an option for RT auto-derivation to use RFC 8635. #2034

Merged
merged 1 commit into from May 16, 2018

Conversation

Projects
None yet
7 participants
@vincentbernat
Copy link
Contributor

vincentbernat commented Apr 6, 2018

RFC 8635 explains how RT auto-derivation should be done in section
5.1.2.1
. In addition to encoding the VNI in the lowest bytes, a
3-bit field is used to encode a namespace. For VXLAN, we have to put 1
in this field. This is needed for proper interoperability with RT
auto-derivation in JunOS. Since this would break existing setup, an
additional option, "advertise-autort-rfc8365" is used.

@LabN-CI

This comment has been minimized.

Copy link

LabN-CI commented Apr 6, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/2034 099584d
Date 04/06/2018
Start 08:15:30
Finish 08:38:26
Run-Time 22:56
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2018-04-06-08:15:30.txt
Log autoscript-2018-04-06-08:16:18.log.bz2

For details, please contact louberger

@NetDEF-CI

This comment has been minimized.

Copy link
Collaborator

NetDEF-CI commented Apr 6, 2018

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3232/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for bgp_evpn.c
===============================================
< WARNING: Missing a blank line after declarations
< #3237: FILE: /tmp/f1-18078/bgp_evpn.c:3237:
< +	struct ecommunity *ecom;
< +	if (!vpn) {
--
< WARNING: __func__ should be used instead of gcc specific __FUNCTION__
< #3238: FILE: /tmp/f1-18078/bgp_evpn.c:3238:
< +		zlog_warn("%s: VNI hash entry for VNI not found", __FUNCTION__);
< 
Report for bgp_evpn_vty.c
===============================================
< WARNING: line over 80 characters
< #4507: FILE: /tmp/f1-18078/bgp_evpn_vty.c:4507:
< +	install_element(BGP_EVPN_NODE, &no_bgp_evpn_advertise_autort_rfc8365_cmd);
< 

CLANG Static Analyzer Summary

  • Github Pull Request 2034, comparing to Git base SHA 0c842c4

No Changes in Static Analysis warnings compared to base

19 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3232/artifact/shared/static_analysis/index.html

struct bgpevpn *vpn = backet->data;
struct listnode *node, *nnode;
struct ecommunity *ecom;
if (!vpn) {

This comment has been minimized.

@donaldsharp

donaldsharp Apr 7, 2018

Member

We try to put an empty line here to separate out the variable declarations and actual code.

struct listnode *node, *nnode;
struct ecommunity *ecom;
if (!vpn) {
zlog_warn("%s: VNI hash entry for VNI not found", __FUNCTION__);

This comment has been minimized.

@donaldsharp

donaldsharp Apr 7, 2018

Member

PRETTY_FUNCTION or func

@donaldsharp

This comment has been minimized.

Copy link
Member

donaldsharp commented Apr 7, 2018

@vincentbernat Can we add a Signed-off-by: ... line as specified here: https://github.com/FRRouting/frr/blob/master/doc/developer/workflow.rst . I've reviewed the code for grammatical/syntatical issues but have asked @vivek-cumulus and @mkanjari to look at the code for correctness.

@vincentbernat vincentbernat force-pushed the vincentbernat:fix/rfc8365-auto-rt branch from 099584d to f6cb539 Apr 7, 2018

@vincentbernat

This comment has been minimized.

Copy link
Contributor

vincentbernat commented Apr 7, 2018

PR updated.

@LabN-CI

This comment has been minimized.

Copy link

LabN-CI commented Apr 7, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/2034 f6cb539
Date 04/07/2018
Start 01:40:28
Finish 02:03:40
Run-Time 23:12
Total 1816
Pass 1816
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2018-04-07-01:40:28.txt
Log autoscript-2018-04-07-01:41:16.log.bz2

For details, please contact louberger

@NetDEF-CI

This comment has been minimized.

Copy link
Collaborator

NetDEF-CI commented Apr 7, 2018

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3246/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for bgp_evpn.c
===============================================
< WARNING: line over 80 characters
< #3239: FILE: /tmp/f1-24398/bgp_evpn.c:3239:
< +		zlog_warn("%s: VNI hash entry for VNI not found", __PRETTY_FUNCTION__);
< 
Report for bgp_evpn_vty.c
===============================================
< WARNING: line over 80 characters
< #4507: FILE: /tmp/f1-24398/bgp_evpn_vty.c:4507:
< +	install_element(BGP_EVPN_NODE, &no_bgp_evpn_advertise_autort_rfc8365_cmd);
< 

CLANG Static Analyzer Summary

  • Github Pull Request 2034, comparing to Git base SHA 8227cf9

Fixed warnings:

  • Logic error: Dereference of null pointer in ospf6d/ospf6_intra.c, function ospf6_intra_prefix_lsa_remove, line 1851

Static Analysis warning summary compared to base:

  • Fixed warnings: 1
  • New warnings: 0

19 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3246/artifact/shared/static_analysis/index.html

@@ -2655,6 +2673,33 @@ DEFUN (no_bgp_evpn_advertise_all_vni,
return CMD_SUCCESS;
}

DEFUN (bgp_evpn_advertise_autort_rfc8365,
bgp_evpn_advertise_autort_rfc8365_cmd,
"advertise-autort-rfc8365",

This comment has been minimized.

@mkanjari

mkanjari Apr 8, 2018

Contributor

I have a few comments/suggestions here:
0. Can we think about making this the default behaviour and remove this command ? It will be good to know if all major vendors adhere to this format.

  1. could we please change this command to be something more user friendly instead of referring to a specific RFC?

This comment has been minimized.

@vincentbernat

vincentbernat Apr 9, 2018

Contributor

For 0, this would break existing setups, notably for your customers. But the patch would be far simpler if there was no option.

For 1, open to suggestions.

This comment has been minimized.

@mkanjari

mkanjari Apr 13, 2018

Contributor

I think it will be okay to make this the default encoding. this will create a problem only when different switches run different versions of FRR (might not be that common).
Lets wait for @vivek-cumulus inputs.

This comment has been minimized.

@vincentbernat

vincentbernat Apr 13, 2018

Contributor

Customers upgrading from one FRR version to a new one will break their whole setup.

This comment has been minimized.

@mkanjari

mkanjari Apr 13, 2018

Contributor

Yes, you are right.

*/
void bgp_evpn_handle_autort_change(struct bgp *bgp)
{
hash_iterate(bgp->vnihash,

This comment has been minimized.

@mkanjari

mkanjari Apr 8, 2018

Contributor

We should also change the import/export RTs for l3-vni to follow this encoding as well.

This comment has been minimized.

@vincentbernat

vincentbernat Apr 9, 2018

Contributor

I am not familiar with the concept of a L3 VNI. From my understanding, just having a non-zero IP address in type 2 routes is not enough, right? It seems there is an additiona VNI number. Could you point me to an RFC section?

This comment has been minimized.

@mkanjari

mkanjari Apr 13, 2018

Contributor

I think we can open a new bug/issue here and handle it at a separate commit. But we do need to follow the same encoding for l2-vnis and l3-vnis.

@vincentbernat

This comment has been minimized.

Copy link
Contributor

vincentbernat commented Apr 8, 2018

I may not totally understand RFC 8365. Until today, I have always seen JunOS send a RT with the "VXLAN" bit set to 1. But, I now have a configuration where the RT target is just AS:VNI. I don't see what could have triggered this. On the other hand, just sending IMET with AS:VNI is not enough for JunOS. You either have to send it as AS:VXLAN+VNI or add appropriate etag and label matching the VNI.

@vincentbernat

This comment has been minimized.

Copy link
Contributor

vincentbernat commented Apr 9, 2018

Please, ignore my last comment, I had a left-over of the previous configuration where I was forcing the RT on the JunOS side. Once it's cleaned, I consistently have the "VXLAN flag" set.

@vincentbernat

This comment has been minimized.

Copy link
Contributor

vincentbernat commented Apr 10, 2018

So, with this PR + #2035 + #2041, I am able to interoperate with a Juniper vQFX 17.1R4 as long as it doesn't use active-active Ethernet segments. When using active-active multi-homed segments, there seems to be some other issues I'll investigate later (most notably, unicast MAC would have to be put once in the kernel, but that's not my current problem). I may end up implementing Type-1 and Type-4 routes to support multi-homed segments. However, I would need to add "discard" entries in the FDB (and optionally, ECMP for unicast routes, but that's not mandatory to make it work). Also, I am running out of time for this. Is this on the roadmap for Cumulus?

@donaldsharp

This comment has been minimized.

Copy link
Member

donaldsharp commented Apr 10, 2018

https://lists.frrouting.org/pipermail/dev/2018-March/001147.html

@vincentbernat we would welcome other people looking at this and working on it with us imo.

@donaldsharp

This comment has been minimized.

Copy link
Member

donaldsharp commented Apr 12, 2018

@mkanjari are your concerns addre3ssed?

@mkanjari

This comment has been minimized.

Copy link
Contributor

mkanjari commented Apr 13, 2018

@donaldsharp @vincentbernat : Changes as such looks good to me. It would be good if we could:

  1. make this the default encoding scheme provided we don't break existing setups
  2. CLI needs a better name (not able to think of one though)
    will wait for @vivek-cumulus for inputs.

@vincentbernat : On a side note, I had started working on type-1/type-4 implementation sometime back too, should have a first version soon.

@vivek-cumulus

This comment has been minimized.

Copy link
Contributor

vivek-cumulus commented Apr 20, 2018

@vincentbernat - thank you for this very useful change which you'd mentioned about a while ago.

My preference is to stick with the approach of introducing a configuration, as in our testing, we haven't seen this set by another vendor. One suggestion on the command name would be "autort rfc8365-compatible" - we do have something similar in OSPF.

We can handle changes to "L3 VNI" as a separate commit. That's nothing but the "label-2" in section 5.1.1 of https://tools.ietf.org/html/draft-ietf-bess-evpn-inter-subnet-forwarding-03.

@vincentbernat vincentbernat force-pushed the vincentbernat:fix/rfc8365-auto-rt branch from f6cb539 to 6d57b13 Apr 23, 2018

bgpd: add an option for RT auto-derivation to use RFC 8635.
RFC 8635 explains how RT auto-derivation should be done in section
5.1.2.1 [1]. In addition to encoding the VNI in the lowest bytes, a
3-bit field is used to encode a namespace. For VXLAN, we have to put 1
in this field. This is needed for proper interoperability with RT
auto-derivation in JunOS. Since this would break existing setup, an
additional option, "autort rfc8365-compatible" is used.

[1]: https://tools.ietf.org/html/rfc8365#section-5.1.2.1

Signed-off-by: Vincent Bernat <vincent@bernat.im>

@vincentbernat vincentbernat force-pushed the vincentbernat:fix/rfc8365-auto-rt branch from 6d57b13 to bf1061d Apr 23, 2018

@vincentbernat

This comment has been minimized.

Copy link
Contributor

vincentbernat commented Apr 23, 2018

@vivek-cumulus I renamed the option to autort rfc8365-compatible, like you suggested.

As for L3 VNI, I didn't know this draft. I'll welcome to fix that in another PR since I am currently quite short in time.

@NetDEF-CI

This comment has been minimized.

Copy link
Collaborator

NetDEF-CI commented Apr 23, 2018

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3415/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

CentOS 7 rpm pkg check: Successful
Ubuntu 12.04 deb pkg check: Successful
IPv6 protocols on Ubuntu 14.04: Successful
Ubuntu 16.04 deb pkg check: Successful
CentOS 6 rpm pkg check: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful
Ubuntu 14.04 deb pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
IPv4 protocols on Ubuntu 14.04: Successful
Fedora 24 rpm pkg check: Successful
Debian 9 deb pkg check: Successful
Static analyzer (clang): Successful

Topology tests on Ubuntu 16.04 amd64: Failed

Topology tests on Ubuntu 16.04 amd64: Unknown Log <memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3415/artifact/TOPOU1604/MemoryLeaks/memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt
Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-3415/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

2018-04-23 08:27:00,305 ERROR: ******************************************************************************
2018-04-23 08:27:00,306 ERROR: Test Target Summary                                                  Pass Fail
2018-04-23 08:27:00,307 ERROR: ******************************************************************************
2018-04-23 08:27:00,307 ERROR: FILE: scripts/adjacencies.py
2018-04-23 08:27:00,307 ERROR: FILE: scripts/check_routes.py
2018-04-23 08:27:00,307 ERROR: 26   ce3    Cust 1 routes from remote                                0    1
2018-04-23 08:27:00,307 ERROR: 26   ce4    Cust 2 routes from remote                                0    1
2018-04-23 08:27:00,308 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2018-04-23 08:27:00,310 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 2 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3415/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topotest tests on Ubuntu 16.04 i386: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-3415/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

2018-04-23 08:26:57,885 ERROR: ******************************************************************************
2018-04-23 08:26:57,885 ERROR: Test Target Summary                                                  Pass Fail
2018-04-23 08:26:57,885 ERROR: ******************************************************************************
2018-04-23 08:26:57,885 ERROR: FILE: scripts/adjacencies.py
2018-04-23 08:26:57,885 ERROR: FILE: scripts/check_routes.py
2018-04-23 08:26:57,886 ERROR: 26   ce3    Cust 1 routes from remote                                0    1
2018-04-23 08:26:57,886 ERROR: 26   ce4    Cust 2 routes from remote                                0    1
2018-04-23 08:26:57,886 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2018-04-23 08:26:57,887 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 2 tests failed
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3415/artifact/TOPOI386/ErrorLog/log_topotests.txt
Topotest tests on Ubuntu 16.04 i386: Unknown Log <memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3415/artifact/TOPOI386/MemoryLeaks/memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt


Warnings Generated during build:

Checkout code: Successful with additional warnings:

Topology tests on Ubuntu 16.04 amd64: Failed

Topology tests on Ubuntu 16.04 amd64: Unknown Log <memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3415/artifact/TOPOU1604/MemoryLeaks/memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt
Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-3415/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

2018-04-23 08:27:00,305 ERROR: ******************************************************************************
2018-04-23 08:27:00,306 ERROR: Test Target Summary                                                  Pass Fail
2018-04-23 08:27:00,307 ERROR: ******************************************************************************
2018-04-23 08:27:00,307 ERROR: FILE: scripts/adjacencies.py
2018-04-23 08:27:00,307 ERROR: FILE: scripts/check_routes.py
2018-04-23 08:27:00,307 ERROR: 26   ce3    Cust 1 routes from remote                                0    1
2018-04-23 08:27:00,307 ERROR: 26   ce4    Cust 2 routes from remote                                0    1
2018-04-23 08:27:00,308 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2018-04-23 08:27:00,310 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 2 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3415/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topotest tests on Ubuntu 16.04 i386: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-3415/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

2018-04-23 08:26:57,885 ERROR: ******************************************************************************
2018-04-23 08:26:57,885 ERROR: Test Target Summary                                                  Pass Fail
2018-04-23 08:26:57,885 ERROR: ******************************************************************************
2018-04-23 08:26:57,885 ERROR: FILE: scripts/adjacencies.py
2018-04-23 08:26:57,885 ERROR: FILE: scripts/check_routes.py
2018-04-23 08:26:57,886 ERROR: 26   ce3    Cust 1 routes from remote                                0    1
2018-04-23 08:26:57,886 ERROR: 26   ce4    Cust 2 routes from remote                                0    1
2018-04-23 08:26:57,886 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2018-04-23 08:26:57,887 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 2 tests failed
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3415/artifact/TOPOI386/ErrorLog/log_topotests.txt
Topotest tests on Ubuntu 16.04 i386: Unknown Log <memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3415/artifact/TOPOI386/MemoryLeaks/memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt

Report for bgp_evpn.c
===============================================
< WARNING: line over 80 characters
< #3249: FILE: /tmp/f1-18152/bgp_evpn.c:3249:
< +		zlog_warn("%s: VNI hash entry for VNI not found", __PRETTY_FUNCTION__);
< 
Report for bgp_evpn_vty.c
===============================================
< WARNING: line over 80 characters
< #4507: FILE: /tmp/f1-18152/bgp_evpn_vty.c:4507:
< +	install_element(BGP_EVPN_NODE, &no_bgp_evpn_advertise_autort_rfc8365_cmd);
< 

CLANG Static Analyzer Summary

  • Github Pull Request 2034, comparing to Git base SHA 8aeee10

New warnings:

Static Analysis warning summary compared to base:

  • Fixed warnings: 0
  • New warnings: 13

19 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3415/artifact/shared/static_analysis/index.html

@LabN-CI

This comment has been minimized.

Copy link

LabN-CI commented Apr 23, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/2034 bf1061d
Date 04/23/2018
Start 11:33:37
Finish 11:56:45
Run-Time 23:08
Total 1816
Pass 1816
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2018-04-23-11:33:37.txt
Log autoscript-2018-04-23-11:34:28.log.bz2

For details, please contact louberger

@NetDEF-CI

This comment has been minimized.

Copy link
Collaborator

NetDEF-CI commented Apr 23, 2018

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Static analyzer (clang): Successful
Ubuntu 12.04 deb pkg check: Successful
Ubuntu 16.04 deb pkg check: Successful
IPv6 protocols on Ubuntu 14.04: Successful
CentOS 6 rpm pkg check: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful
Ubuntu 14.04 deb pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
IPv4 protocols on Ubuntu 14.04: Successful
Fedora 24 rpm pkg check: Successful
Debian 9 deb pkg check: Successful
CentOS 7 rpm pkg check: Successful

Topology tests on Ubuntu 16.04 amd64: Failed

Topology tests on Ubuntu 16.04 amd64: Unknown Log <memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/TOPOU1604/MemoryLeaks/memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt
Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-3416/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

2018-04-23 08:56:08,478 ERROR: ******************************************************************************
2018-04-23 08:56:08,479 ERROR: Test Target Summary                                                  Pass Fail
2018-04-23 08:56:08,479 ERROR: ******************************************************************************
2018-04-23 08:56:08,479 ERROR: FILE: scripts/adjacencies.py
2018-04-23 08:56:08,479 ERROR: FILE: scripts/check_routes.py
2018-04-23 08:56:08,479 ERROR: 26   ce3    Cust 1 routes from remote                                0    1
2018-04-23 08:56:08,479 ERROR: 26   ce4    Cust 2 routes from remote                                0    1
2018-04-23 08:56:08,481 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2018-04-23 08:56:08,483 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 2 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topotest tests on Ubuntu 16.04 i386: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-3416/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

2018-04-23 08:56:03,742 ERROR: ******************************************************************************
2018-04-23 08:56:03,742 ERROR: Test Target Summary                                                  Pass Fail
2018-04-23 08:56:03,742 ERROR: ******************************************************************************
2018-04-23 08:56:03,742 ERROR: FILE: scripts/adjacencies.py
2018-04-23 08:56:03,742 ERROR: FILE: scripts/check_routes.py
2018-04-23 08:56:03,743 ERROR: 26   ce3    Cust 1 routes from remote                                0    1
2018-04-23 08:56:03,743 ERROR: 26   ce4    Cust 2 routes from remote                                0    1
2018-04-23 08:56:03,743 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2018-04-23 08:56:03,743 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 2 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/TOPOI386/ErrorLog/log_topotests.txt
Topotest tests on Ubuntu 16.04 i386: Unknown Log <memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/TOPOI386/MemoryLeaks/memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt


Warnings Generated during build:

Checkout code: Successful with additional warnings:

Topology tests on Ubuntu 16.04 amd64: Failed

Topology tests on Ubuntu 16.04 amd64: Unknown Log <memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/TOPOU1604/MemoryLeaks/memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt
Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-3416/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

2018-04-23 08:56:08,478 ERROR: ******************************************************************************
2018-04-23 08:56:08,479 ERROR: Test Target Summary                                                  Pass Fail
2018-04-23 08:56:08,479 ERROR: ******************************************************************************
2018-04-23 08:56:08,479 ERROR: FILE: scripts/adjacencies.py
2018-04-23 08:56:08,479 ERROR: FILE: scripts/check_routes.py
2018-04-23 08:56:08,479 ERROR: 26   ce3    Cust 1 routes from remote                                0    1
2018-04-23 08:56:08,479 ERROR: 26   ce4    Cust 2 routes from remote                                0    1
2018-04-23 08:56:08,481 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2018-04-23 08:56:08,483 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 2 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topotest tests on Ubuntu 16.04 i386: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-3416/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

2018-04-23 08:56:03,742 ERROR: ******************************************************************************
2018-04-23 08:56:03,742 ERROR: Test Target Summary                                                  Pass Fail
2018-04-23 08:56:03,742 ERROR: ******************************************************************************
2018-04-23 08:56:03,742 ERROR: FILE: scripts/adjacencies.py
2018-04-23 08:56:03,742 ERROR: FILE: scripts/check_routes.py
2018-04-23 08:56:03,743 ERROR: 26   ce3    Cust 1 routes from remote                                0    1
2018-04-23 08:56:03,743 ERROR: 26   ce4    Cust 2 routes from remote                                0    1
2018-04-23 08:56:03,743 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2018-04-23 08:56:03,743 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 2 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/TOPOI386/ErrorLog/log_topotests.txt
Topotest tests on Ubuntu 16.04 i386: Unknown Log <memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/TOPOI386/MemoryLeaks/memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt

Report for bgp_evpn.c
===============================================
< WARNING: line over 80 characters
< #3249: FILE: /tmp/f1-11742/bgp_evpn.c:3249:
< +		zlog_warn("%s: VNI hash entry for VNI not found", __PRETTY_FUNCTION__);
< 
Report for bgp_evpn_vty.c
===============================================
< WARNING: line over 80 characters
< #4509: FILE: /tmp/f1-11742/bgp_evpn_vty.c:4509:
< +	install_element(BGP_EVPN_NODE, &no_bgp_evpn_advertise_autort_rfc8365_cmd);
< 

CLANG Static Analyzer Summary

  • Github Pull Request 2034, comparing to Git base SHA 84abd23

New warnings:

Static Analysis warning summary compared to base:

  • Fixed warnings: 0
  • New warnings: 13

19 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/shared/static_analysis/index.html

@donaldsharp

This comment has been minimized.

Copy link
Member

donaldsharp commented May 9, 2018

@vivek-cumulus is this the change you wanted?

@NetDEF-CI

This comment has been minimized.

Copy link
Collaborator

NetDEF-CI commented May 9, 2018

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Static analyzer (clang): Successful
Ubuntu 12.04 deb pkg check: Successful
Ubuntu 16.04 deb pkg check: Successful
IPv6 protocols on Ubuntu 14.04: Successful
CentOS 6 rpm pkg check: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful
Ubuntu 14.04 deb pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
IPv4 protocols on Ubuntu 14.04: Successful
Fedora 24 rpm pkg check: Successful
Debian 9 deb pkg check: Successful
CentOS 7 rpm pkg check: Successful

Topology tests on Ubuntu 16.04 amd64: Failed

Topology tests on Ubuntu 16.04 amd64: Unknown Log <memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/TOPOU1604/MemoryLeaks/memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt
Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-3416/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

2018-05-09 04:59:11,827 ERROR: ******************************************************************************
2018-05-09 04:59:11,827 ERROR: Test Target Summary                                                  Pass Fail
2018-05-09 04:59:11,827 ERROR: ******************************************************************************
2018-05-09 04:59:11,827 ERROR: FILE: scripts/adjacencies.py
2018-05-09 04:59:11,827 ERROR: FILE: scripts/check_routes.py
2018-05-09 04:59:11,827 ERROR: 46   ce3    Cust 1 routes from remote                                0    1
2018-05-09 04:59:11,827 ERROR: 47   ce4    Cust 2 routes from remote                                0    1
2018-05-09 04:59:11,827 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2018-05-09 04:59:11,830 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 2 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topotest tests on Ubuntu 16.04 i386: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-3416/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

2018-05-09 04:58:58,859 ERROR: ******************************************************************************
2018-05-09 04:58:58,859 ERROR: Test Target Summary                                                  Pass Fail
2018-05-09 04:58:58,859 ERROR: ******************************************************************************
2018-05-09 04:58:58,859 ERROR: FILE: scripts/adjacencies.py
2018-05-09 04:58:58,859 ERROR: FILE: scripts/check_routes.py
2018-05-09 04:58:58,859 ERROR: 46   ce3    Cust 1 routes from remote                                0    1
2018-05-09 04:58:58,859 ERROR: 47   ce4    Cust 2 routes from remote                                0    1
2018-05-09 04:58:58,860 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2018-05-09 04:58:58,860 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 2 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/TOPOI386/ErrorLog/log_topotests.txt
Topotest tests on Ubuntu 16.04 i386: Unknown Log <memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/TOPOI386/MemoryLeaks/memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt


Warnings Generated during build:

Checkout code: Successful with additional warnings:

Topology tests on Ubuntu 16.04 amd64: Failed

Topology tests on Ubuntu 16.04 amd64: Unknown Log <memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/TOPOU1604/MemoryLeaks/memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt
Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-3416/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

2018-05-09 04:59:11,827 ERROR: ******************************************************************************
2018-05-09 04:59:11,827 ERROR: Test Target Summary                                                  Pass Fail
2018-05-09 04:59:11,827 ERROR: ******************************************************************************
2018-05-09 04:59:11,827 ERROR: FILE: scripts/adjacencies.py
2018-05-09 04:59:11,827 ERROR: FILE: scripts/check_routes.py
2018-05-09 04:59:11,827 ERROR: 46   ce3    Cust 1 routes from remote                                0    1
2018-05-09 04:59:11,827 ERROR: 47   ce4    Cust 2 routes from remote                                0    1
2018-05-09 04:59:11,827 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2018-05-09 04:59:11,830 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 2 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topotest tests on Ubuntu 16.04 i386: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-3416/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

2018-05-09 04:58:58,859 ERROR: ******************************************************************************
2018-05-09 04:58:58,859 ERROR: Test Target Summary                                                  Pass Fail
2018-05-09 04:58:58,859 ERROR: ******************************************************************************
2018-05-09 04:58:58,859 ERROR: FILE: scripts/adjacencies.py
2018-05-09 04:58:58,859 ERROR: FILE: scripts/check_routes.py
2018-05-09 04:58:58,859 ERROR: 46   ce3    Cust 1 routes from remote                                0    1
2018-05-09 04:58:58,859 ERROR: 47   ce4    Cust 2 routes from remote                                0    1
2018-05-09 04:58:58,860 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2018-05-09 04:58:58,860 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 2 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/TOPOI386/ErrorLog/log_topotests.txt
Topotest tests on Ubuntu 16.04 i386: Unknown Log <memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/TOPOI386/MemoryLeaks/memleak_bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf.txt

Report for bgp_evpn.c
===============================================
< WARNING: line over 80 characters
< #3249: FILE: /tmp/f1-11742/bgp_evpn.c:3249:
< +		zlog_warn("%s: VNI hash entry for VNI not found", __PRETTY_FUNCTION__);
< 
Report for bgp_evpn_vty.c
===============================================
< WARNING: line over 80 characters
< #4509: FILE: /tmp/f1-11742/bgp_evpn_vty.c:4509:
< +	install_element(BGP_EVPN_NODE, &no_bgp_evpn_advertise_autort_rfc8365_cmd);
< 

CLANG Static Analyzer Summary

  • Github Pull Request 2034, comparing to Git base SHA 84abd23

New warnings:

Static Analysis warning summary compared to base:

  • Fixed warnings: 0
  • New warnings: 13

19 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3416/artifact/shared/static_analysis/index.html

@vivek-cumulus

This comment has been minimized.

Copy link
Contributor

vivek-cumulus commented May 16, 2018

Sounds good, as far as I'm concerned, this PR is fine.

@donaldsharp donaldsharp merged commit 51f9d3e into FRRouting:master May 16, 2018

1 check failed

default Tested by NetDEF/OpenSourceRouting CI System
Details
@vjardin

This comment has been minimized.

Copy link

vjardin commented Jun 23, 2018

Just record Vincent's blog for those who need to use EVPN
https://vincent.bernat.im/fr/blog/2017-vxlan-bgp-evpn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment