Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yang: embed models into binaries #3361

Merged
merged 2 commits into from Nov 26, 2018

Conversation

eqvinox
Copy link
Contributor

@eqvinox eqvinox commented Nov 19, 2018

This bakes our YANG models straight into the library/daemons, so they
don't need to be loaded from /usr/share/yang. This makes the
installation quite a bit more robust, as well as gets us halfway to
running uninstalled. (The other half is baking in the extension type
module.)

The /usr/share/yang directory is still searched as a fallback, as well
as for the experimental YANG model translator. This is likely to stay
as is for the time being.

Signed-off-by: David Lamparter equinox@diac24.net

Components

  • lib/yang

@NetDEF-CI

This comment has been minimized.

@LabN-CI

This comment has been minimized.

Copy link
Member

@rwestphal rwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot! Pretty cool stuff :)

The BSD errors can probably be fixed by including zebra.h before yang.h in the auto-generated files.

This bakes our YANG models straight into the library/daemons, so they
don't need to be loaded from /usr/share/yang.  This makes the
installation quite a bit more robust, as well as gets us halfway to
running uninstalled.  (The other half is baking in the extension type
module.)

The /usr/share/yang directory is still searched as a fallback, as well
as for the experimental YANG model translator.  This is likely to stay
as is for the time being.

Signed-off-by: David Lamparter <equinox@diac24.net>
Signed-off-by: David Lamparter <equinox@diac24.net>
@LabN-CI

This comment has been minimized.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Nov 19, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/3361 9fd4742
Date 11/19/2018
Start 18:20:14
Finish 18:43:57
Run-Time 23:43
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2018-11-19-18:20:14.txt
Log autoscript-2018-11-19-18:20:55.log.bz2

For details, please contact louberger

@NetDEF-CI

This comment has been minimized.

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5974/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 3361, comparing to Git base SHA dc079d4

No Changes in Static Analysis warnings compared to base

@riw777 riw777 merged commit 0c9503e into FRRouting:master Nov 26, 2018
@eqvinox eqvinox deleted the yang-embed-models branch April 18, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants