Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] ldpd: *BSD fixes #4254

Merged
merged 3 commits into from May 3, 2019

Conversation

@mwinter-osr
Copy link
Member

commented May 3, 2019

PR #3527 applied to 6.0

Summary

This PR is a collection of fixes I've made while trying to run ldpd on FreeBSD/OpenBSD following the official instructions.

Changes:

  • Make FreeBSD at least start the socket to connect to ldpd neighbors, even though it doesn't support any MPLS route installation;
  • Fix OpenBSD compilation: version 6.4 doesn't have the define RTM_LOCK anymore ( https://marc.info/?l=openbsd-tech&m=153018811429193&w=2 ).
  • Fix ldpd PF key socket start on OpenBSD: it must be open before the privilege drop.

Components

zebra, ldpd

rzalamena added 3 commits Dec 21, 2018
We must open the PF_KEY socket before dropping privileges, otherwise the
socket creation will fail with permission problems.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
OpenBSD doesn't define RTM_LOCK anymore:
https://marc.info/?l=openbsd-tech&m=153018811429193&w=2

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Add yet another way to setsockopt a socket to listen to a foreign
address.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
@mwinter-osr mwinter-osr added this to the 6.0.3 milestone May 3, 2019
@LabN-CI

This comment has been minimized.

Copy link

commented May 3, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4254 16927ec
Date 05/03/2019
Start 18:16:14
Finish 18:40:21
Run-Time 24:07
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-05-03-18:16:14.txt
Log autoscript-2019-05-03-18:17:03.log.bz2
Memory 435 424 364

For details, please contact louberger

@NetDEF-CI

This comment has been minimized.

Copy link
Collaborator

commented May 3, 2019

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7485/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 4254, comparing to Git base SHA 4a36086

No Changes in Static Analysis warnings compared to base

75 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7485/artifact/shared/static_analysis/index.html

@donaldsharp donaldsharp merged commit eaefb84 into FRRouting:stable/6.0 May 3, 2019
1 check passed
1 check passed
default Tested by NetDEF/OpenSourceRouting CI System
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.