Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isisd: Expand send/receive buffers to allow for larger mtu #6066

Merged
merged 1 commit into from Mar 21, 2020

Conversation

@donaldsharp
Copy link
Member

@donaldsharp donaldsharp commented Mar 21, 2020

User is reporting:
2020/03/21 03:12:36 ISIS: isis_send_pdu_bcast: sock_buff size 8192 is less than output pdu size 9014 on circuit em0
2020/03/21 03:12:36 ISIS: [EC 67108865] ISIS-Adj (1): Send L2 IIH on em0 failed

MTU's can frequently hit 9k in size, we have buffer limits
that prevent this from being fully used and creating errors.

Modify the code to allow for up to 16k mtu

Signed-off-by: Donald Sharp sharpd@cumulusnetworks.com

User is reporting:
2020/03/21 03:12:36 ISIS: isis_send_pdu_bcast: sock_buff size 8192 is less than output pdu size 9014 on circuit em0
2020/03/21 03:12:36 ISIS: [EC 67108865] ISIS-Adj (1): Send L2 IIH on em0 failed

MTU's can frequently hit 9k in size, we have buffer limits
that prevent this from being fully used and creating errors.

Modify the code to allow for up to 16k mtu

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@LabN-CI
Copy link
Collaborator

@LabN-CI LabN-CI commented Mar 21, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/6066 207a142
Date 03/21/2020
Start 08:30:29
Finish 08:56:24
Run-Time 25:55
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-03-21-08:30:29.txt
Log autoscript-2020-03-21-08:31:24.log.bz2
Memory 493 459 418

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

@NetDEF-CI NetDEF-CI commented Mar 21, 2020

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11364/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11364/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200321-00-g207a14293-0 (missing) -> 7.4-dev-20200321-00-g207a14293-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200321-00-g207a14293-0 (missing) -> 7.4-dev-20200321-00-g207a14293-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200321-00-g207a14293-0 (missing) -> 7.4-dev-20200321-00-g207a14293-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200321-00-g207a14293-0 (missing) -> 7.4-dev-20200321-00-g207a14293-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200321-00-g207a14293-0 (missing) -> 7.4-dev-20200321-00-g207a14293-0~deb10u1
@eqvinox eqvinox merged commit 3f1ba9b into FRRouting:master Mar 21, 2020
2 checks passed
2 checks passed
ci/dockercloud (/tests/topotests) Your tests passed in Docker Cloud
Details
default Tested by NetDEF/OpenSourceRouting CI System
Details
@donaldsharp donaldsharp deleted the donaldsharp:isis_mtu_buffer branch Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants