Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use configfile mode in init script #6383

Merged
merged 1 commit into from May 13, 2020

Conversation

eqvinox
Copy link
Contributor

@eqvinox eqvinox commented May 11, 2020

This only applies for split-config; the init script would create an
empty config file with default permissions.

This only applies for split-config;  the init script would create an
empty config file with default permissions.

Reported-by: Robert Scheck <robert@fedoraproject.org>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
@eqvinox
Copy link
Contributor Author

eqvinox commented May 11, 2020

(v2: fixed the old init script too. we should really remove that.)

@LabN-CI
Copy link
Collaborator

LabN-CI commented May 11, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/6383 5c90637
Date 05/11/2020
Start 16:32:43
Finish 16:58:38
Run-Time 25:55
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-05-11-16:32:43.txt
Log autoscript-2020-05-11-16:33:47.log.bz2
Memory 485 498 425

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented May 11, 2020

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12253/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12253/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200511-05-g2e40fbaa1-0 (missing) -> 7.5-dev-20200511-05-g2e40fbaa1-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200511-05-g2e40fbaa1-0 (missing) -> 7.5-dev-20200511-05-g2e40fbaa1-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200511-05-g2e40fbaa1-0 (missing) -> 7.5-dev-20200511-05-g2e40fbaa1-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200511-05-g2e40fbaa1-0 (missing) -> 7.5-dev-20200511-05-g2e40fbaa1-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200511-05-g2e40fbaa1-0 (missing) -> 7.5-dev-20200511-05-g2e40fbaa1-0~deb10u1

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12254/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12254/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200511-05-g5c9063771-0 (missing) -> 7.5-dev-20200511-05-g5c9063771-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200511-05-g5c9063771-0 (missing) -> 7.5-dev-20200511-05-g5c9063771-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200511-05-g5c9063771-0 (missing) -> 7.5-dev-20200511-05-g5c9063771-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200511-05-g5c9063771-0 (missing) -> 7.5-dev-20200511-05-g5c9063771-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200511-05-g5c9063771-0 (missing) -> 7.5-dev-20200511-05-g5c9063771-0~deb10u1

@ton31337 ton31337 merged commit 7734484 into FRRouting:master May 13, 2020
@eqvinox eqvinox deleted the init-config-perms branch April 18, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants