zebra: move ip rule installation to use dplane thread #6465

xThaid · 2020-05-26T16:51:24Z

I've converted PBR rules installation code to use dplane thread. I've also written a small topotest testing if rule is installed in OS.

Resolves #6415

LabN-CI · 2020-05-26T17:21:55Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6465 `d69c2b3`
Date	05/26/2020
Start	12:55:46
Finish	13:21:50
Run-Time	26:04
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-05-26-12:55:46.txt
Log	autoscript-2020-05-26-12:56:52.log.bz2
Memory	490 492 424

For details, please contact louberger

NetDEF-CI · 2020-05-26T18:47:00Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12428/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-12428/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-05-26 19:31:09,278 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 19:31:11,352 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 19:31:17,530 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 19:42:43,472 ERROR: assert failed at "test_pbr_topo1/test_rule_linux_installation": Router r1 OS rules mismatch
assert Generated JSON diff error report:
  
  > $->410: d2 has key 'proto' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12428/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-12428/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-05-26 19:30:19,513 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 19:30:21,558 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 19:30:27,706 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 19:41:47,808 ERROR: assert failed at "test_pbr_topo1/test_rule_linux_installation": Router r1 OS rules mismatch
assert Generated JSON diff error report:
  
  > $->410: d2 has key 'proto' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12428/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-12428/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-05-26 17:30:11,372 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 17:30:13,426 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 17:30:19,593 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 17:41:40,292 ERROR: assert failed at "test_pbr_topo1/test_rule_linux_installation": Router r1 OS rules mismatch
assert Generated JSON diff error report:
  
  > $->410: d2 has key 'proto' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12428/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topo tests part 1 on Ubuntu 18.04 amd64
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 2
Debian 8 deb pkg check
IPv4 protocols on Ubuntu 18.04
Topo tests part 2 on Ubuntu 16.04 amd64
CentOS 7 rpm pkg check
Debian 10 deb pkg check
IPv4 ldp protocol on Ubuntu 18.04
Debian 9 deb pkg check
Addresssanitizer topotests part 0
Topo tests part 2 on Ubuntu 18.04 amd64
Topo tests part 1 on Ubuntu 16.04 amd64
Static analyzer (clang)
Fedora 29 rpm pkg check
Addresssanitizer topotests part 1
Ubuntu 20.04 deb pkg check
Ubuntu 16.04 deb pkg check
Topo tests part 2 on Ubuntu 16.04 i386
Topo tests part 1 on Ubuntu 16.04 i386
IPv6 protocols on Ubuntu 18.04

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-12428/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-05-26 19:31:09,278 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 19:31:11,352 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 19:31:17,530 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 19:42:43,472 ERROR: assert failed at "test_pbr_topo1/test_rule_linux_installation": Router r1 OS rules mismatch
assert Generated JSON diff error report:
  
  > $->410: d2 has key 'proto' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12428/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-12428/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-05-26 19:30:19,513 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 19:30:21,558 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 19:30:27,706 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 19:41:47,808 ERROR: assert failed at "test_pbr_topo1/test_rule_linux_installation": Router r1 OS rules mismatch
assert Generated JSON diff error report:
  
  > $->410: d2 has key 'proto' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12428/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-12428/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-05-26 17:30:11,372 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 17:30:13,426 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 17:30:19,593 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-05-26 17:41:40,292 ERROR: assert failed at "test_pbr_topo1/test_rule_linux_installation": Router r1 OS rules mismatch
assert Generated JSON diff error report:
  
  > $->410: d2 has key 'proto' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12428/artifact/TOPOU1804/ErrorLog/log_topotests.txt

<stdin>:131: trailing whitespace.
! 
<stdin>:173: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
Report for pbrd.conf | 4 issues
===============================================
ERROR: trailing whitespace
#11: FILE: /tmp/f1-17732/pbrd.conf:11:
+! $

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12428/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200526-12-gd69c2b30c-0 (missing) -> 7.5-dev-20200526-12-gd69c2b30c-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200526-12-gd69c2b30c-0 (missing) -> 7.5-dev-20200526-12-gd69c2b30c-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200526-12-gd69c2b30c-0 (missing) -> 7.5-dev-20200526-12-gd69c2b30c-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200526-12-gd69c2b30c-0 (missing) -> 7.5-dev-20200526-12-gd69c2b30c-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200526-12-gd69c2b30c-0 (missing) -> 7.5-dev-20200526-12-gd69c2b30c-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 6465, comparing to Git base SHA eeec40b
Base image data for Git eeec40b does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12428/artifact/shared/static_analysis/index.html

LabN-CI · 2020-05-27T21:21:56Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6465 `110c1fd`
Date	05/27/2020
Start	16:55:47
Finish	17:21:50
Run-Time	26:03
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-05-27-16:55:47.txt
Log	autoscript-2020-05-27-16:56:49.log.bz2
Memory	496 496 425

For details, please contact louberger

NetDEF-CI · 2020-05-27T22:46:06Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12447/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12447/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200527-01-g110c1fdb6-0 (missing) -> 7.5-dev-20200527-01-g110c1fdb6-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200527-01-g110c1fdb6-0 (missing) -> 7.5-dev-20200527-01-g110c1fdb6-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200527-01-g110c1fdb6-0 (missing) -> 7.5-dev-20200527-01-g110c1fdb6-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200527-01-g110c1fdb6-0 (missing) -> 7.5-dev-20200527-01-g110c1fdb6-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200527-01-g110c1fdb6-0 (missing) -> 7.5-dev-20200527-01-g110c1fdb6-0~deb10u1

pguibert6WIND · 2020-05-29T09:49:29Z

Hi,
it seems ok at first sight.
I wanted to know if you would be motivated to also apply the changes to iptable and ipset api.
the zapi hooks are IPTABLE_ADD/DELETE and IPSET_CREATE/DESTROY and IPSET_ENTRY_ADD/DELETE.

what happens here is that BGP flowspec will attempt to push in a specific order the following: ip rule, iptable entries, ipset entries

The fear is that ip rule may be delayed, because implemented in the dataplane thread, and not the first thread.

would it be possible to support iptable, ipset, ipset_entry contexts in the dataplane ?

sworleys · 2020-05-29T15:34:40Z

Hi,
it seems ok at first sight.
I wanted to know if you would be motivated to also apply the changes to iptable and ipset api.
the zapi hooks are IPTABLE_ADD/DELETE and IPSET_CREATE/DESTROY and IPSET_ENTRY_ADD/DELETE.

what happens here is that BGP flowspec will attempt to push in a specific order the following: ip rule, iptable entries, ipset entries

The fear is that ip rule may be delayed, because implemented in the dataplane thread, and not the first thread.

would it be possible to support iptable, ipset, ipset_entry contexts in the dataplane ?

Hey @pguibert6WIND @xThaid is our GSOC student working on dataplane batching so i gave him this assignment to get him used to that area of the code. He will start working on the dataplane batching project June 1st so I dont think he will have time to add more to this before then.

Could you open an issue with what you want and then he can work on it later this summer if he has time?

LabN-CI · 2020-06-01T16:41:29Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git pull/6465 `49d057b` (merge failed)
Date	06/01/2020
Start	12:15:28
Finish	12:41:23
Run-Time	25:55
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-06-01-12:15:28.txt
Log	autoscript-2020-06-01-12:16:27.log.bz2
Memory	476 500 425

For details, please contact louberger

LabN-CI · 2020-06-01T17:46:56Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6465 `c1a5c83`
Date	06/01/2020
Start	13:20:46
Finish	13:46:50
Run-Time	26:04
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-06-01-13:20:46.txt
Log	autoscript-2020-06-01-13:21:49.log.bz2
Memory	495 491 425

For details, please contact louberger

NetDEF-CI · 2020-06-01T18:09:09Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12513/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12513/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200601-00-g49d057b49-0 (missing) -> 7.5-dev-20200601-00-g49d057b49-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200601-00-g49d057b49-0 (missing) -> 7.5-dev-20200601-00-g49d057b49-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200601-00-g49d057b49-0 (missing) -> 7.5-dev-20200601-00-g49d057b49-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200601-00-g49d057b49-0 (missing) -> 7.5-dev-20200601-00-g49d057b49-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200601-00-g49d057b49-0 (missing) -> 7.5-dev-20200601-00-g49d057b49-0~deb10u1

NetDEF-CI · 2020-06-01T19:10:23Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12514/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12514/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200601-08-gc1a5c8324-0 (missing) -> 7.5-dev-20200601-08-gc1a5c8324-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200601-08-gc1a5c8324-0 (missing) -> 7.5-dev-20200601-08-gc1a5c8324-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200601-08-gc1a5c8324-0 (missing) -> 7.5-dev-20200601-08-gc1a5c8324-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200601-08-gc1a5c8324-0 (missing) -> 7.5-dev-20200601-08-gc1a5c8324-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200601-08-gc1a5c8324-0 (missing) -> 7.5-dev-20200601-08-gc1a5c8324-0~deb10u1

LabN-CI · 2020-06-01T21:03:00Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6465 `1978083`
Date	06/01/2020
Start	16:36:48
Finish	17:02:53
Run-Time	26:05
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-06-01-16:36:48.txt
Log	autoscript-2020-06-01-16:37:52.log.bz2
Memory	498 499 425

For details, please contact louberger

NetDEF-CI · 2020-06-01T22:21:26Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12520/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12520/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200601-08-g19780832c-0 (missing) -> 7.5-dev-20200601-08-g19780832c-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200601-08-g19780832c-0 (missing) -> 7.5-dev-20200601-08-g19780832c-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200601-08-g19780832c-0 (missing) -> 7.5-dev-20200601-08-g19780832c-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200601-08-g19780832c-0 (missing) -> 7.5-dev-20200601-08-g19780832c-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200601-08-g19780832c-0 (missing) -> 7.5-dev-20200601-08-g19780832c-0~deb10u1

pguibert6WIND · 2020-06-02T15:29:58Z

sure @sworleys. hope really it can be done, since it brings some inconsistencies there.

This commit is the first step to convert IP rule installation to use dplane thread. * Add dataplane's internal representation of a pbr rule * Add dplane stats related to rules * Introduce a new type of dplane operation Signed-off-by: Jakub Urbańczyk <xthaid@gmail.com>

* Implement new dataplane operations * Convert existing code to use dataplane context object * Modify function preparing netlink message to use dataplane context object Signed-off-by: Jakub Urbańczyk <xthaid@gmail.com>

Add some basic tests for installing PBR rules into the kernel. Signed-off-by: Jakub Urbańczyk <xthaid@gmail.com>

Signed-off-by: Jakub Urbańczyk <xthaid@gmail.com>

NetDEF-CI · 2020-06-10T16:23:45Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12609/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12609/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200610-15-g99e387d58-0 (missing) -> 7.5-dev-20200610-15-g99e387d58-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200610-15-g99e387d58-0 (missing) -> 7.5-dev-20200610-15-g99e387d58-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200610-15-g99e387d58-0 (missing) -> 7.5-dev-20200610-15-g99e387d58-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200610-15-g99e387d58-0 (missing) -> 7.5-dev-20200610-15-g99e387d58-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200610-15-g99e387d58-0 (missing) -> 7.5-dev-20200610-15-g99e387d58-0~deb10u1

LabN-CI · 2020-06-10T16:23:51Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/6465 `99e387d`
Date	06/10/2020
Start	11:57:53
Finish	12:23:44
Run-Time	25:51
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-06-10-11:57:53.txt
Log	autoscript-2020-06-10-11:58:52.log.bz2
Memory	497 500 429

For details, please contact louberger

polychaeta added the zebra label May 26, 2020

sworleys assigned sworleys and unassigned sworleys May 26, 2020

sworleys self-requested a review May 26, 2020 17:00

sworleys added the tests Topotests, make check, etc label May 26, 2020

mjstapp self-requested a review May 26, 2020 17:15

xThaid force-pushed the iprules branch from d69c2b3 to 110c1fd Compare May 27, 2020 20:51

xThaid force-pushed the iprules branch from 49d057b to c1a5c83 Compare June 1, 2020 17:15

xThaid force-pushed the iprules branch from c1a5c83 to 1978083 Compare June 1, 2020 20:25

xThaid added 4 commits June 10, 2020 16:18

zebra: convert ip rule installation to use dplane thread

f62e548

* Implement new dataplane operations * Convert existing code to use dataplane context object * Modify function preparing netlink message to use dataplane context object Signed-off-by: Jakub Urbańczyk <xthaid@gmail.com>

topotest: add pbr test suite

9b7decf

Add some basic tests for installing PBR rules into the kernel. Signed-off-by: Jakub Urbańczyk <xthaid@gmail.com>

zebra: separate code encoding netlink msg

99e387d

Signed-off-by: Jakub Urbańczyk <xthaid@gmail.com>

xThaid force-pushed the iprules branch from 1978083 to 99e387d Compare June 10, 2020 14:30

sworleys approved these changes Jun 10, 2020

View reviewed changes

sworleys merged commit 5e0494b into FRRouting:master Jun 10, 2020

xThaid deleted the iprules branch July 18, 2020 11:12

zebra: move ip rule installation to use dplane thread #6465

zebra: move ip rule installation to use dplane thread #6465

Conversation

xThaid commented May 26, 2020

LabN-CI commented May 26, 2020 • edited

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented May 26, 2020 • edited

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

Warnings Generated during build:

CLANG Static Analyzer Summary

1 Static Analyzer issues remaining.

LabN-CI commented May 27, 2020 • edited

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented May 27, 2020 • edited

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

pguibert6WIND commented May 29, 2020

sworleys commented May 29, 2020

LabN-CI commented Jun 1, 2020 • edited

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Jun 1, 2020 • edited

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jun 1, 2020 • edited

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Jun 1, 2020 • edited

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

LabN-CI commented Jun 1, 2020 • edited

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jun 1, 2020 • edited

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

pguibert6WIND commented Jun 2, 2020

NetDEF-CI commented Jun 10, 2020

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

LabN-CI commented Jun 10, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented May 26, 2020 •

edited

NetDEF-CI commented May 26, 2020 •

edited

LabN-CI commented May 27, 2020 •

edited

NetDEF-CI commented May 27, 2020 •

edited

LabN-CI commented Jun 1, 2020 •

edited

LabN-CI commented Jun 1, 2020 •

edited

NetDEF-CI commented Jun 1, 2020 •

edited

NetDEF-CI commented Jun 1, 2020 •

edited

LabN-CI commented Jun 1, 2020 •

edited

NetDEF-CI commented Jun 1, 2020 •

edited