bgpd: Some backports to 7.4

[ton31337]

bgpd: Actually find the sequence number for large-community-list
bgpd: Return bool type for ecommunity_add_val and subgroup_announce_check

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/6679 d5a157b
Date	07/05/2020
Start	15:10:17
Finish	15:36:15
Run-Time	25:58
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-07-05-15:10:17.txt
Log	autoscript-2020-07-05-15:11:16.log.bz2
Memory	500 499 425

For details, please contact louberger

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12969/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Ubuntu 16.04 i386 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12969/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Debian 9 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12969/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Ubuntu 16.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12969/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Ubuntu 18.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12969/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Ubuntu 18.04 arm7 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 arm7 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12969/artifact/U18ARM7BUILD/ErrorLog/log_lintian.txt)

W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Ubuntu 20.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 20.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12969/artifact/U2004AMD64BUILD/ErrorLog/log_lintian.txt)

W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Ubuntu 18.04 arm8 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 arm8 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12969/artifact/U18ARM8BUILD/ErrorLog/log_lintian.txt)

W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Debian 8 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12969/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Ubuntu 18.04 ppc64le build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12969/artifact/U1804PPC64LEBUILD/ErrorLog/log_lintian.txt)

W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Ubuntu 16.04 arm8 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 arm8 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12969/artifact/U16ARM8BUILD/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Ubuntu 16.04 arm7 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 arm7 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12969/artifact/CI101BUILD/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12969/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-snmp: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-snmp: changelog-file-missing-explicit-entry 7.4-0 -> 7.4-20200705-01-gd5a157b7c-0 (missing) -> 7.4-20200705-01-gd5a157b7c-0~deb10u1
W: frr-pythontools: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-pythontools: changelog-file-missing-explicit-entry 7.4-0 -> 7.4-20200705-01-gd5a157b7c-0 (missing) -> 7.4-20200705-01-gd5a157b7c-0~deb10u1
W: frr-doc: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-doc: changelog-file-missing-explicit-entry 7.4-0 -> 7.4-20200705-01-gd5a157b7c-0 (missing) -> 7.4-20200705-01-gd5a157b7c-0~deb10u1
W: frr: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr: changelog-file-missing-explicit-entry 7.4-0 -> 7.4-20200705-01-gd5a157b7c-0 (missing) -> 7.4-20200705-01-gd5a157b7c-0~deb10u1
W: frr-rpki-rtrlib: syntax-error-in-debian-changelog line 119 "found start of entry where expected more change data or trailer"
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 7.4-0 -> 7.4-20200705-01-gd5a157b7c-0 (missing) -> 7.4-20200705-01-gd5a157b7c-0~deb10u1