bgpd: Allow peer-groups to have ttl-security hops configured
#7873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command `neighbor PGROUP ttl-security hops X` was being accepted but ignored. Allow it to be stored. I am still not sure that this is applied correctly, but that is another problem. Fixes: FRRouting#7848 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
donaldsharp
force-pushed
the
bgp_gtsm_peer_group_fix
branch
from
8a66632
to
4ec7a71
Compare
ton31337
approved these changes
Jan 15, 2021
Outdated results 🚧Basic BGPD CI results: Partial FAILURE, 1 tests failed
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16544/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16546/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
|
@louberger what went wrong? |
|
seeing more errors due to code running slower ;-( will rerun...
…On 1/17/2021 8:17 PM, Donald Sharp wrote:
@louberger <https://github.com/louberger> what went wrong?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7873 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSFNSFLDTOBK32TXQSETQ3S2ODZBANCNFSM4WEBLA4Q>.
|
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
neighbor PGROUP ttl-security hops Xwas beingaccepted but ignored. Allow it to be stored. I am still
not sure that this is applied correctly, but that is another
problem.
Fixes: #7848
Signed-off-by: Donald Sharp sharpd@nvidia.com