Skip to content
Permalink
Browse files

bgp-ecmp-topo1: fix some pylint warnings

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  • Loading branch information...
rzalamena committed Nov 6, 2018
1 parent 5a87c58 commit 57ed2311568ac6bafe793b979df562ef9338a9cd
Showing with 16 additions and 11 deletions.
  1. +16 −11 bgp-ecmp-topo1/test_bgp_ecmp_topo1.py
@@ -48,11 +48,12 @@
total_ebgp_peers = 20

#####################################################
##
## Network Topology Definition
##
#
# Network Topology Definition
#
#####################################################


class BGPECMPTopo1(Topo):
"BGP ECMP Topology 1"

@@ -63,13 +64,13 @@ def build(self, **_opts):
router = tgen.add_router('r1')

# Setup Switches - 1 switch per 5 peering routers
for swNum in range(1, (total_ebgp_peers+4)/5 +1):
for swNum in range(1, (total_ebgp_peers + 4) / 5 + 1):
switch = tgen.add_switch('s{}'.format(swNum))
switch.add_link(router)

# Add 'total_ebgp_peers' number of eBGP ExaBGP neighbors
for peerNum in range(1, total_ebgp_peers+1):
swNum = ((peerNum -1) / 5 + 1)
swNum = ((peerNum - 1) / 5 + 1)

peer_ip = '10.0.{}.{}'.format(swNum, peerNum + 100)
peer_route = 'via 10.0.{}.1'.format(swNum)
@@ -81,9 +82,9 @@ def build(self, **_opts):


#####################################################
##
## Tests starting
##
#
# Tests starting
#
#####################################################

def setup_module(module):
@@ -112,10 +113,12 @@ def setup_module(module):
peer.start(peer_dir, env_file)
logger.info(pname)


def teardown_module(module):
tgen = get_topogen()
tgen.stop_topology()


def test_bgp_convergence():
"Test for BGP topology convergence"
tgen = get_topogen()
@@ -135,8 +138,8 @@ def test_bgp_convergence():

def _output_summary_cmp(router, cmd, data):
"""
Runs `cmd` that returns JSON data (normally the command ends with 'json')
and compare with `data` contents.
Runs `cmd` that returns JSON data (normally the command ends
with 'json') and compare with `data` contents.
"""
output = router.vtysh_cmd(cmd, isjson=True)
if 'ipv4Unicast' in output:
@@ -153,6 +156,7 @@ def _output_summary_cmp(router, cmd, data):
assertmsg = 'BGP router network did not converge'
assert res is None, assertmsg


def test_bgp_ecmp():
tgen = get_topogen()

@@ -175,11 +179,12 @@ def test_bgp_ecmp():
expect['routes'][netkey].append(peer)

test_func = functools.partial(topotest.router_json_cmp,
tgen.gears['r1'], 'show ip bgp json', expect)
tgen.gears['r1'], 'show ip bgp json', expect)
_, res = topotest.run_and_expect(test_func, None, count=10, wait=0.5)
assertmsg = 'expected multipath routes in "show ip bgp" output'
assert res is None, assertmsg


if __name__ == '__main__':
args = ["-s"] + sys.argv[1:]
sys.exit(pytest.main(args))

0 comments on commit 57ed231

Please sign in to comment.
You can’t perform that action at this time.