Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Can't compile ngx_postgres with nginx-1.5.3 #19

Closed
an0ma1ia opened this Issue Jul 31, 2013 · 6 comments

Comments

Projects
None yet
3 participants

...
gmake[1]: Entering directory /home/ano/1/nginx/nginx-1.5.3' cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -DNDK_SET_VAR -DNDK_SET_VAR -DNDK_UPSTREAM_LIST -DNDK_SET_VAR -DNDK_SET_VAR -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../ngx_devel_kit/objs -I objs/addon/ndk -I /usr/include/pgsql -I ../lua-nginx-module-0.8.4/src/api -I objs -I src/http -I src/http/modules -I ../ngx_devel_kit/src -I src/mail \ -o objs/addon/src/ngx_postgres_upstream.o \ ../ngx_postgres/src/ngx_postgres_upstream.c ../ngx_postgres/src/ngx_postgres_upstream.c: In function ‘ngx_postgres_upstream_init’: ../ngx_postgres/src/ngx_postgres_upstream.c:107:43: error: passing argument 2 of ‘ngx_sock_ntop’ makes integer from pointer without a cast [-Werror] In file included from src/core/ngx_core.h:69:0, from ../ngx_postgres/src/ngx_postgres_ddebug.h:32, from ../ngx_postgres/src/ngx_postgres_upstream.c:34: src/core/ngx_inet.h:110:8: note: expected ‘socklen_t’ but argument is of type ‘u_char *’ ../ngx_postgres/src/ngx_postgres_upstream.c:107:43: error: passing argument 3 of ‘ngx_sock_ntop’ makes pointer from integer without a cast [-Werror] In file included from src/core/ngx_core.h:69:0, from ../ngx_postgres/src/ngx_postgres_ddebug.h:32, from ../ngx_postgres/src/ngx_postgres_upstream.c:34: src/core/ngx_inet.h:110:8: note: expected ‘u_char *’ but argument is of type ‘long unsigned int’ ../ngx_postgres/src/ngx_postgres_upstream.c:107:43: error: too few arguments to function ‘ngx_sock_ntop’ In file included from src/core/ngx_core.h:69:0, from ../ngx_postgres/src/ngx_postgres_ddebug.h:32, from ../ngx_postgres/src/ngx_postgres_upstream.c:34: src/core/ngx_inet.h:110:8: note: declared here cc1: all warnings being treated as errors gmake[1]: *** [objs/addon/src/ngx_postgres_upstream.o] Error 1 gmake[1]: Leaving directory/home/ano/1/nginx/nginx-1.5.3'
gmake: *** [build] Error 2

agentzh added a commit that referenced this issue Jul 31, 2013

bugfix: compilation error happened with nginx 1.5.3+ because nginx ch…
…anges the ngx_sock_ntop API. thanks an0ma1ia for the report in #19.
Contributor

agentzh commented Jul 31, 2013

Just fixed in master. Thanks for the report!

@agentzh agentzh closed this Jul 31, 2013

msva commented Aug 3, 2013

Hi! Can't you make a tag with fixed for 1.5.3 version.

Contributor

agentzh commented Aug 3, 2013

@msva Just ask @PiotrSikora to tag a new release.

msva commented Aug 4, 2013

ok, I ask @PiotrSikora to tag new release [by this comment :)]

Contributor

agentzh commented Aug 5, 2013

@msva I've just tagged 1.0rc3. @PiotrSikora needs to do more testing before the 1.0 formal release (or something like that).

msva commented Aug 6, 2013

Thanks a lot!

06.08.2013 03:23, Yichun Zhang пишет:

@msva https://github.com/msva I've just tagged 1.0rc3. @PiotrSikora
https://github.com/PiotrSikora needs to do more testing before the 1.0
formal release (or something like that).


Reply to this email directly or view it on GitHub
#19 (comment).

Lance0312 added a commit to Lance0312/archlinux-nginx-lua-postgres that referenced this issue Apr 28, 2014

Update to nginx-1.6.0
Also update ngx_postgres to 1.0rc3 to fix
issue FRiCKLE/ngx_postgres#19

Signed-off-by: Lance Chen <cyen0312@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment