New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace IOLoop.update_handler with remove_handler and add_handler #38

Merged
merged 1 commit into from Jan 6, 2013

Conversation

Projects
None yet
2 participants
@Bart-Jellema
Contributor

Bart-Jellema commented Jan 6, 2013

Using IOLoop.update_handler was causing issues with Exception handling in tornado.gen in the host application to the extend that the errors were returned on the wrong RequestHandler. Even other code errors. I assume it has something to do with the StackContext. add_handler creates a new StackContext, but update_handler doesn't.

Using IOLoop.update_handler was causing issues with Exception handlin…
…g in tornado.gen in the host application to the extend that the errors were returned on the wrong RequestHandler. I assume it has something to do with the StackContext.

FSX added a commit that referenced this pull request Jan 6, 2013

Merge pull request #38 from Bart-Jellema/master
Replace IOLoop.update_handler with remove_handler and add_handler

@FSX FSX merged commit 7ad5f5c into FSX:master Jan 6, 2013

@FSX

This comment has been minimized.

Owner

FSX commented Jan 6, 2013

Thanks! :)

@FSX

This comment has been minimized.

Owner

FSX commented Jan 6, 2013

Hey, I made a few changes your pull request after I looked at the code more carefully. Here's the commit, everything is explained in the commit message: 92940db. It's in the develop branch for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment