Do not discard names in elab_env. #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm tired of looking at log files without variable names because we replace them with
xbefore passing them to F*.Before:
try_teq of FStar.Pervasives.Native.tuple2 and FStar.Pervasives.Native.tuple2 in [Binding_var x, Binding_var x, Binding_var x, Binding_var x, Binding_var x, Binding_var x] {After:
try_teq of FStar.Pervasives.Native.tuple2 and FStar.Pervasives.Native.tuple2 in [Binding_var __, Binding_var v, Binding_var i, Binding_var p, Binding_var s, Binding_var t] {The only awkward part is that we used to use the binder name
_a lot. However this name is treated specially in F*, in particular assumptions with this name seem to be dropped in the SMT encoding. Therefore this PR changes the name to__instead. Right before extraction we change it back to_, because obviously the underscore is magic in extraction as well.