Skip to content
This repository has been archived by the owner on Sep 25, 2021. It is now read-only.

Iridium Ore in Industrial Grinder #58

Closed
mtimyself opened this issue May 21, 2018 · 9 comments
Closed

Iridium Ore in Industrial Grinder #58

mtimyself opened this issue May 21, 2018 · 9 comments
Labels
recipe issue Issues with custom recipes submitted to moddev Extra attention is needed

Comments

@mtimyself
Copy link

  • Modpack Version: 1.0.2
  • Issue:
    When putting Iridium Ore into the TR Industrial Grinder it yields 1 Ingot (not Dust) and 2 small piles of platinum dust.
    Iridium can be "ore doubled" via the TR Grinder and the IE Crusher, both of which are considerably lower tech level.
    If for some reason, that I can not yet see, the Industrial Grinder is not supposed to double the Iridium then surely it should still output it in its dust form.
@Xavion3
Copy link

Xavion3 commented May 21, 2018

This is caused by some mod interactions, by default in tech reborn you can only process iridium ore in the industrial grinder for the one ingot. Due to other mods adding iridium ore and compat abounding it gets the doubling recipes.

Tech Reborn's intended progression is get the rare ores at 1 ingot each to get enough to get UU matter to start producing it yourself I believe, this pack twists that a bit but results in some oddities like this as a result.

@tfox83 tfox83 added the recipe issue Issues with custom recipes label May 21, 2018
@tfox83
Copy link
Contributor

tfox83 commented May 23, 2018

Going to have @modmuss50 take a look at this:
I tried this and it doesn't remove or add the recipe:

mods.techreborn.industrialGrinder.removeInputRecipe(<thermalfoundation:ore:7>);
mods.techreborn.industrialGrinder.addRecipe(<thermalfoundation:material:135> * 2, <techreborn:smalldust:38> * 2, null, null, <thermalfoundation:ore:7>, <liquid:water> * 1000, 300, 40);

@tfox83 tfox83 added the submitted to moddev Extra attention is needed label May 23, 2018
@modmuss50
Copy link

@tfox83 adding recipes seems to work fine, let me know if its still broken in the full pack and ill take another look.

screen shot 2018-05-24 at 11 06 45

As for removing this recipe you need to use the ore dict name (as the recipe was registed using the ore dict name, im not sure why crafttweaker isnt saying they match (Code: https://github.com/TechReborn/TechReborn/blob/1.12/src/main/java/techreborn/compat/crafttweaker/CTGeneric.java#L108).

But when testing using the following:

mods.techreborn.industrialGrinder.removeInputRecipe(<ore:oreIridium>);

removing the recipe seems to work just fine, and provides the above uses for iridium ore. I can look into making the removal a bit more lenient when checking if the inputs are equal.

@modmuss50
Copy link

Also, that example recipe you provided has a slight issue causing the fluid to not be used.

mods.techreborn.industrialGrinder.addRecipe(<thermalfoundation:material:135> * 2, <techreborn:smalldust:38> * 2, null, null, <thermalfoundation:ore:7>, null, <liquid:water> * 1000, 300, 40);

Works, note the extra null for the 2nd input, as before it was trying to use the fluid on the 2nd input slot, but now this uses the other method that uses the fluid tank.

@Kuktar
Copy link

Kuktar commented May 24, 2018 via email

@modmuss50
Copy link

No, I dont @Kuktar best thing you can do it just enjoy the mod 👍

modmuss50 added a commit to TechReborn/TechReborn that referenced this issue May 24, 2018
…um#58

Hopefully this doesnt break scripts, let me know if it does ;)
@Kuktar
Copy link

Kuktar commented May 24, 2018 via email

@tfox83
Copy link
Contributor

tfox83 commented May 24, 2018

Ok great, thanks Modmuss, ill get those changes into the next dev version and let you know if I have anymore problems.

@tfox83
Copy link
Contributor

tfox83 commented May 31, 2018

Fixed in next version
image

@tfox83 tfox83 closed this as completed May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
recipe issue Issues with custom recipes submitted to moddev Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants