From b0c5c3fdfa67801b633c5da5c2cad4eacf4fa8ae Mon Sep 17 00:00:00 2001 From: Des Herriott Date: Tue, 21 May 2024 08:45:51 +0100 Subject: [PATCH 1/2] fix: large itemstack sizes when creating tasks leading to empty stacks int->byte casting issue in vanilla ItemStack#save https://github.com/FTBTeam/FTB-Mods-Issues/issues/1182 --- .../main/java/dev/ftb/mods/ftbquests/item/MissingItem.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/common/src/main/java/dev/ftb/mods/ftbquests/item/MissingItem.java b/common/src/main/java/dev/ftb/mods/ftbquests/item/MissingItem.java index cfbade75..67bac175 100644 --- a/common/src/main/java/dev/ftb/mods/ftbquests/item/MissingItem.java +++ b/common/src/main/java/dev/ftb/mods/ftbquests/item/MissingItem.java @@ -53,6 +53,11 @@ public static CompoundTag writeItem(ItemStack stack) { SNBTCompoundTag tag = new SNBTCompoundTag(); stack.save(tag); + // kludge: vanilla saves the stack size as a byte, which means negative sizes for big stacks, + // leading to the stack turning into an empty (air) stack + // https://github.com/FTBTeam/FTB-Mods-Issues/issues/1182 + tag.putInt("Count", stack.getCount()); + if (tag.size() == 2) { tag.singleLine(); } From 614208fefa282a4cd9f660cb2ed71efe620d90f4 Mon Sep 17 00:00:00 2001 From: Des Herriott Date: Tue, 21 May 2024 08:47:19 +0100 Subject: [PATCH 2/2] build: version -> 2001.4.4, changelog updated --- CHANGELOG.md | 5 +++++ gradle.properties | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a15ff1b6..9b625e3a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [2001.4.4] + +### Fixed +* Fixed issue where larger itemstack sizes when creating item tasks led to a "missing" (empty) item in the task + ## [2001.4.3] ### Fixed diff --git a/gradle.properties b/gradle.properties index 4b4fa99c..94fae70c 100644 --- a/gradle.properties +++ b/gradle.properties @@ -5,7 +5,7 @@ mod_id=ftbquests archives_base_name=ftb-quests minecraft_version=1.20.1 # Build time -mod_version=2001.4.3 +mod_version=2001.4.4 maven_group=dev.ftb.mods mod_author=FTB Team # Curse release