1.20.4 port #716
Merged
1.20.4 port #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires some fixes from ftb lib for guis but other than that, seems to be working nicely. Only main note is that advancements are borked with their background due to ftb lib and so is the item selection screen and any standard buttons
feat: port to 1.20.2
Multiple images can now be selected for moving. Quests/quest links and images can be selected and moved together. Ctrl-A now includes images when selecting everything. FTBTeam/FTB-Mods-Issues#1016
When a chapter is switched to via the chapter panel, or via 0-9/Tab hotkeys, the panel automatically centers on the autofocused quest, if any. The autofocused quest can be defined in chapter properties, or by right-clicking a quest and selecting "Set Autofocused" or "Clear Autofocused" as appropriate. FTBTeam/FTB-Mods-Issues#1012
While playing All the Mods 9 it likes to randomly crash when switching dimensions.
- Added filtering abstraction layer via ItemFilterAdapter - No more hard dependency on Item Filters - Supports Item Filters and FTB Filter System via FTB XMod Compat
image components in quest description now display! image align works correctly fixed translations in editor screen
Don't search all submittable tasks when an item is crafted; search only those tasks which have the onlyFromCrafting property set to true (use a cached list) FTBTeam/FTB-Mods-Issues#1063
Dumb parenthesis error
Images can now be copied with keyboard controls Objects can now be copied without selecting; if no objects are selected, Ctrl-C will copy the hovered quest or image, if any FTBTeam/FTB-Mods-Issues#1076
World created with cheats off, but then opened to LAN with cheats on required a quest reload to actually enable editing. FTBTeam/FTB-Mods-Issues#1046
- only post the CustomFilterDisplayItemsEvent once, no need to post every time computeMatchingStacks() is called (cache result, purge when the existing cache is purged) - reduce calls to CreativeModeTabs.tryRebuildTabContents() - only call when there are no items in the search tab FTBTeam/FTB-Mods-Issues#1086
Although all quest progress is reset when a player leaves a party (to the point where they joined the party), claimed-reward data should be preserved so that rewards can't be claimed more than once by a player. FTBTeam/FTB-Mods-Issues#1089
Useful for some quest shapes where the icon might extend beyond the shape edges (e.g. diamond shape)
Use 'dependency_line_uncompleted_color' setting in ftb_quests_theme.txt Default is #C4CCA3A3, which is the same as the colour used previously FTBTeam/FTB-Mods-Issues#1106
requires updated FTB Library 2001.2.0
changelog brought up to date wrt latest 1.20.1
Drop the nasty hack of setting ChapterImageButton#shouldDraw to false and rendering them separately. Now using the new FTB Library draw-layer functionality. Also use new color picker for chapter image and loot crate colouring.
No need to store separate fluid/amount/tag in the task, that's exactly what FluidStack does already. Amount and tag can both now be edited in fluid selector GUI.
MichaelHillcox
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big PR, but does include a lot of commits which have already gone into the 1.20.1 releases.