Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software ripples for GL renderer #1475

Merged
merged 10 commits into from
Oct 31, 2023
Merged

Software ripples for GL renderer #1475

merged 10 commits into from
Oct 31, 2023

Conversation

a1batross
Copy link
Member

We just update textures here.

This version differs from my older version I did for Yamagi Quake 2, just to be sure, I rechecked it with decompile and compared it against original sw.dll, that's why it uses only 64x64 despite drawing texture at 128x128.

I want this merged with the current CPU-based solution, as I believe someone smart will later make a GPU-based solution, and we would be able to compare if it will be any better.

@a1batross
Copy link
Member Author

Comparison:

Usual ref_gl water:

glwater_in_gl.mp4

Software water in WON Half-Life:

swwater_in_swdll_pixelated.mp4

Software water in ref_gl (with nearest filter):

swwater_in_gl_pixelated.mp4

Software water in ref_gl (with linear filter):

swwater_in_gl.mp4

@SNMetamorph
Copy link
Member

I think we need to add "authentic water" option checkbox to video settings.

@Magic-Nipples
Copy link

Works like a charm!! Thanks so much for getting this ported to xash and making it work in gl!!

Magic-Nipples added a commit to Magic-Nipples/Xash3D-VS2019-Clean that referenced this pull request Oct 30, 2023
@a1batross
Copy link
Member Author

Made faster version that only uploads texture of a selected size. So on green sludge texture which is 128x128, it will generate 128x128 texture (viewable in full glory with r_ripple 2), and usual water texture which is 64x64, will render in 64x64.

In mainui_cpp there is a checkbox in Video Options now that toggles r_ripple between 0 and 1.

That's why I said better not take this code yet :)

@a1batross a1batross merged commit e481e1d into master Oct 31, 2023
3 of 17 checks passed
@a1batross a1batross deleted the ripplewater branch October 31, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants