Fix CSS #10
Fix CSS #10
Conversation
Bumps [jekyll-feed](https://github.com/jekyll/jekyll-feed) from 0.11.0 to 0.12.1. - [Release notes](https://github.com/jekyll/jekyll-feed/releases) - [Changelog](https://github.com/jekyll/jekyll-feed/blob/master/History.markdown) - [Commits](jekyll/jekyll-feed@v0.11.0...v0.12.1) Signed-off-by: dependabot[bot] <support@dependabot.com>
…jekyll-feed-0.12.1 Bump jekyll-feed from 0.11.0 to 0.12.1
Bumps [jekyll](https://github.com/jekyll/jekyll) from 3.8.5 to 3.8.6. - [Release notes](https://github.com/jekyll/jekyll/releases) - [Changelog](https://github.com/jekyll/jekyll/blob/master/History.markdown) - [Commits](jekyll/jekyll@v3.8.5...v3.8.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…jekyll-3.8.6 Bump jekyll from 3.8.5 to 3.8.6
Bumps [jekyll-feed](https://github.com/jekyll/jekyll-feed) from 0.12.1 to 0.13.0. - [Release notes](https://github.com/jekyll/jekyll-feed/releases) - [Changelog](https://github.com/jekyll/jekyll-feed/blob/master/History.markdown) - [Commits](jekyll/jekyll-feed@v0.12.1...v0.13.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…jekyll-feed-0.13.0 Bump jekyll-feed from 0.12.1 to 0.13.0
Bumps [jekyll](https://github.com/jekyll/jekyll) from 3.8.6 to 3.8.7. - [Release notes](https://github.com/jekyll/jekyll/releases) - [Changelog](https://github.com/jekyll/jekyll/blob/master/History.markdown) - [Commits](jekyll/jekyll@v3.8.6...v3.8.7) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…jekyll-3.8.7 Bump jekyll from 3.8.6 to 3.8.7
Fixes: FabioRosado#9
|
Ah, it's weird that the netlify deploy is failing -- it's because of using bundler 2.1.4. Any clues? |
There was a problem hiding this comment.
Hello @utkarsh2102,
Again thank you so much for taking the time to fix this issue!
If I'm not mistaken the problem with the deploying happened because you committed your Gemfile.lock, I was using an old version and that was probably why the error happened.
I'm assuming that bundling the whole thing with 2.1.4 will be fine - I should update the whole project sice I'm using an old version of Jekyll as well 😄
Anyway, I've added a suggestion for the menu just because it was breaking a bit on my 13'' screen due to lack of space and I believe using flex and justify to center should work on your end as well 🤔
Co-authored-by: Fábio Rosado <fabioglrosado@gmail.com>
|
Hi @FabioRosado,
Thanks to you, too! 😄
Perfect, works alright now! 💯
Yeah, applied the suggestion; good to go now, I think! :) |
There was a problem hiding this comment.
Again thank you so much for working on this issue @utkarsh2102 - both for spotting the problem and being happy to fix it. I'm happy with these changes and going to merge the PR now 😄 👍
Hi @FabioRosado,
Thanks for working on this awesome project! It looks lovely!
However, there were some CSS problems as reported in #9.
This PR fixes the same 💯 🚀
Hope that helps!
Also, I committed two things separately, using the latest bundler and the fix for CSS. It'd be nice if you don't squash these commits as they're two different things 😄
Fixes: #9