Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix InnerClassGenerator not remapping fields. #98

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Fix InnerClassGenerator not remapping fields. #98

merged 2 commits into from
Feb 13, 2023

Conversation

0-x-2-2
Copy link

@0-x-2-2 0-x-2-2 commented Jan 19, 2023

No description provided.

sfPlayer1
sfPlayer1 approved these changes Jan 28, 2023
View reviewed changes
Copy link

@sfPlayer1 sfPlayer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes about the underlying necessity would be nice

@RaphiMC RaphiMC mentioned this pull request Jan 29, 2023
Closed
@0-x-2-2 0-x-2-2 mentioned this pull request Jan 31, 2023
Open
@0-x-2-2
Copy link
Author

0-x-2-2 commented Jan 31, 2023 •
edited
Loading

Some notes about the underlying necessity would be nice

Not sure what could be included really because it is a simple problem. I posted some stuff in discord but FabricMC/fabric-loom#810 is the same issue.

@modmuss50 modmuss50 merged commit da8566a into FabricMC:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfPlayer1 sfPlayer1 sfPlayer1 approved these changes

@modmuss50 modmuss50 modmuss50 approved these changes

@Chocohead Chocohead Awaiting requested review from Chocohead

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0-x-2-2 @sfPlayer1 @Chocohead @modmuss50