Several tag fixes and additions #3912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 5, 2024
modmuss50
approved these changes
Jul 6, 2024
modmuss50
added
enhancement
|
@modmuss50 One second, I'll deal with the merge conflicts |
|
@modmuss50 Should be good now |
|
Lol, I was doing the same :D Wondered why I couldnt push it lol. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes includes:
Renaming all food tags under
c:foods/to be singular. Example isc:foods/fruitsto bec:foods/fruit. This is because you would say Fruit Foods and not Fruits Foods. Basically, foods is the noun. Fruit is the descriptor of the food noun. Backwards compat added here to reduce breakage for people.Added
c:foods/goldento collect all gold based foods. Which then can be paired ingredient intersections and differences to target or exclude from the other food tags.Added
c:tools/igniterto now have Flint and Steel be considered a tool properly.Adding
c:ender_pearls,c:glass_blocks/colorless,c:glass_blocks/cheap,c:glass_blocks/tinted,c:glass_panes/colorlesstags to match what Neoforge has closer.Neoforge PR: neoforged/NeoForge#1238
Closes: #3899
Closes: #3869
Closes half of : #3895