Skip to content

language file changes #170

Merged
merged 28 commits into from Feb 21, 2012

2 participants

@rw1
rw1 commented Feb 8, 2012

No description provided.

@pollen8 pollen8 and 1 other commented on an outdated diff Feb 9, 2012
...onents/com_fabrik/language/en-GB/en-GB.com_fabrik.ini
@@ -4,8 +4,8 @@
; License http://www.gnu.org/licenses/gpl-2.0.html GNU/GPL, see LICENSE.php
; Note : All ini files need to be saved as UTF-8 - No BOM
-COM_FABRIK_FIELD_RECORD_IN_DATABASE_DESC="Should we store the submitted forms data to a database view?"
-COM_FABRIK_FIELD_RECORD_IN_DATABASE_LABEL="Record in database"
+COM_FABRIK_FIELD_RECORD_IN_DATABASE_DESC="Should we store the submitted forms data to the database table?"
+COM_FABRIK_FIELD_RECORD_IN_DATABASE_LABEL="The lists record number in the database table"
@pollen8
Fabrik member
pollen8 added a note Feb 9, 2012

that really isn't very clear! We are recording in the database, not sure what you think it should say!

@rw1
rw1 added a note Feb 9, 2012

re: COM_FABRIK_FIELD_RECORD_IN_DATABASE_DESC - perhaps i am not familiar with the terminology 'database view' and thought it was easier to understand for the user if it said 'should we record this in the database table' rather than 'should we record this in the database view'. also just trying to assist with the uniform usage of the term 'list' as separate from it's predecessor 'table' whilst still keeping it clear what a lists relationship is with a database table.

re: COM_FABRIK_FIELD_RECORD_IN_DATABASE_LABEL - it is a description of what it is ie 'the list's record number in the database'. perhaps it should be something like 'The lists ID number as stored in the database'?

@pollen8
Fabrik member
pollen8 added a note Feb 15, 2012

For the LABEL this is on the form edit page, where it really is storing to the database, I think we should leave it as "Record in database"

@rw1
rw1 added a note Feb 16, 2012

Confused:

in 3.0.3-130 in /public_html/administrator/components/com_fabrik/language/en-GB/en-GB.com_fabrik.ini there is:

COM_FABRIK_FIELD_RECORD_IN_DATABASE_DESC="Should we store the submitted forms data to a database view?"

COM_FABRIK_FIELD_RECORD_IN_DATABASE_LABEL="Record in database"

which is referenced in /public_html/administrator/components/com_fabrik/models/forms/form.xml with:

    <field name="record_in_database" 

        type="radio" default="1" 

        label="COM_FABRIK_FIELD_RECORD_IN_DATABASE_LABEL" 

        description="COM_FABRIK_FIELD_RECORD_IN_DATABASE_DESC">

            <option value="0">JNO</option>

            <option value="1">JYES</option>

    </field>

And yes, i agree that LABEL is completely accurate in that context.

The instance i think i was wanting to change was the first field called 'ID' in the list edit page.

That seems to be referenced in /public_html/administrator/components/com_fabrik/models/forms/list.xml with:

    <field name="id" 

        type="text" 

        default="0" 

        required="true"

        readonly="true" class="readonly"

        label="JGLOBAL_FIELD_ID_LABEL"  

        description ="JGLOBAL_FIELD_ID_DESC" />

So perhaps i edited the wrong file and line then! And possibly the error was made because ID's DESC 'Record number in the database' is similar to the other fields LABEL 'Record in database'. Woops!

But, in the latest unzipped version (3.0.3-130) i cannot find where 'JGLOBAL_FIELD_ID_DESC' is defined. The DESC is outputting as "Record number in the database' and i can't find that when searching either! But this DESC seems to be the same for form and list edit pages (as seen in form.xml and list.xml) so maybe better to leave untouched!

@rw1
rw1 added a note Feb 16, 2012

have returned LABEL description to previous state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@rw1
rw1 commented on b389611 Feb 14, 2012

could possibly also change:

PLG_VISUALIZATION_FUSIONCHART_TABLE_LABEL

to:

PLG_VISUALIZATION_FUSIONCHART_LIST_LABEL

but wasn't sure if there were any other implications of this proposed change.

searching for:

PLG_VISUALIZATION_FUSIONCHART_TABLE_LABEL

only returned results in:

plugins\fabrik_visualization\fusionchart\language\en-GB\en-GB.plg_fabrik_visualization_fusionchart.ini

and

\plugins\fabrik_visualization\fusionchart\forms\fields.xml

@pollen8 pollen8 merged commit dbbb743 into Fabrik:master Feb 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.