Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Awesomium #531

Closed
DarthTealc opened this issue Jul 9, 2015 · 125 comments
Closed

Replace Awesomium #531

DarthTealc opened this issue Jul 9, 2015 · 125 comments

Comments

@DarthTealc
Copy link

@DarthTealc DarthTealc commented Jul 9, 2015

Awesomium is based on Chrome/Chromium 18 AFAIK. That's way too old. And there's no indication they're going to fix that any time soon.

Can Awesomium please be replaced with a more up-to-date browser implementation? For example "Chromium Embedded Framework" which is used in Steam.

@xaviergmail
Copy link

@xaviergmail xaviergmail commented Jul 9, 2015

I would love for better HTML panel support (As well as the loading screen, because I can't use Canvas in it right now and it makes me very sad)

@P4sca1
Copy link

@P4sca1 P4sca1 commented Jul 16, 2015

It seems like everybody is complaining about Awesonium since months...
I think there should finally be done something.

@P4sca1
Copy link

@P4sca1 P4sca1 commented Jul 16, 2015

This sounds as it will be changed in the near feature. Good job! :D

@willox
Copy link
Contributor

@willox willox commented Jul 16, 2015

This sounds as it will be changed in the near feature. Good job! :D

🌈

@WinterPhoenix
Copy link

@WinterPhoenix WinterPhoenix commented Aug 2, 2015

Cinema is no longer able to play YouTube Videos at above 360p quality due to the limitations of Awesomium. More info here.

Please, please, sooner rather than later, do this.

@jtsalisbury
Copy link

@jtsalisbury jtsalisbury commented Aug 2, 2015

best application 10/10

@aStonedPenguin
Copy link

@aStonedPenguin aStonedPenguin commented Aug 2, 2015

+1

1 similar comment
@marcogravbrot
Copy link

@marcogravbrot marcogravbrot commented Aug 2, 2015

👍

@SwadicalRag
Copy link

@SwadicalRag SwadicalRag commented Aug 2, 2015

💯+

@poseidonservers
Copy link

@poseidonservers poseidonservers commented Aug 25, 2015

Definitely past due, Cinema has become a big part of Garrysmod. ༼ つ ◕_◕ ༽つ Give Replacement

@SpencerJP
Copy link

@SpencerJP SpencerJP commented Aug 25, 2015

+1, don't like Awesomium, a new framework would be better.

@kklouzal
Copy link

@kklouzal kklouzal commented Aug 30, 2015

+1 Replace Awesomium. Use Steam's framework.

@Jake3231
Copy link

@Jake3231 Jake3231 commented Aug 31, 2015

I agree. Along with insufficient support for different things, Awesomium is very unstable and is often the cause of crashes in my game. +1

@gamerpaddy
Copy link

@gamerpaddy gamerpaddy commented Sep 2, 2015

+1 Replace Awesomium, its crashing my game too frequently.

@WinterPhoenix
Copy link

@WinterPhoenix WinterPhoenix commented Oct 21, 2015

@Shigbeard
Copy link

@Shigbeard Shigbeard commented Oct 21, 2015

did I +1 this thing yet? Awesomium is the cancer that's killing GMOD,

Followed closely by Scriptfodder and Skidcheck.

@AnonTakesOver
Copy link

@AnonTakesOver AnonTakesOver commented Oct 21, 2015

+1

@Sophie-bear
Copy link

@Sophie-bear Sophie-bear commented Oct 21, 2015

+1 from me as well. There's really no good reason to use such an outdated and dying API.

@Chewgum
Copy link

@Chewgum Chewgum commented Oct 21, 2015

replace the shit already

@Shigbeard
Copy link

@Shigbeard Shigbeard commented Oct 21, 2015

COUGH

@Kefta
Copy link

@Kefta Kefta commented Oct 21, 2015

Stop spamming; it's already being discussed in the Next Update thread

@aStonedPenguin
Copy link

@aStonedPenguin aStonedPenguin commented Oct 21, 2015

no

@jasmin12e
Copy link

@jasmin12e jasmin12e commented Oct 22, 2015

Please :( I don't want to see cinema just die off..

@xaviergmail
Copy link

@xaviergmail xaviergmail commented Oct 22, 2015

This has nothing to do with JUST cinema. There are many great uses for Awesomium, including but not limited to HTML UI's, which would make many people's lives easier rather than dealing with horrible derma. And please don't say docking. Making responsive UI's that scale well with docking is a pain. It would also help improve our loading screens with cool canvas stuff. I have a beautiful loading screen just sitting in the shitter right now, waiting to see the light of day, and I'm sure many other people have many other cool things waiting. Not to mention the huge performance impact that even further limits what we can do with Lua. Not saying anything else would be performance-tastic, but I would hope so. Rant over.

@Shigbeard
Copy link

@Shigbeard Shigbeard commented Oct 22, 2015

@cannon
Copy link

@cannon cannon commented Oct 23, 2015

JUST DO IT

@ILOVEPIE
Copy link

@ILOVEPIE ILOVEPIE commented Oct 29, 2015

Awsomium needs to be dropped, my suggestion would be to go with the open source alternative to awsomium: https://bitbucket.org/chromiumembedded/cef

@DuckyC
Copy link

@DuckyC DuckyC commented Oct 29, 2015

+1

@Ajbolitt76
Copy link

@Ajbolitt76 Ajbolitt76 commented Jul 18, 2018

@willox will facepunch replace awesomium at next update? The chromium branch looks stable.

@Sophie-bear
Copy link

@Sophie-bear Sophie-bear commented Jul 18, 2018

Chromium is updated and maintained in the same branch as 64-bit builds now from what I can tell from commit logs. https://gmod.facepunch.com/commits
This is not something we have access to yet to really know for sure what it's about, so I guess we'll see.

@ShoryuKyzan
Copy link

@ShoryuKyzan ShoryuKyzan commented Aug 27, 2018

Hell, i'd be willing to do this bit of work. so long as facepunch is willing to release it! (i'm a 10+ year professional software developer)

@LewisTehMinerz
Copy link

@LewisTehMinerz LewisTehMinerz commented Sep 9, 2018

Just want to chip in here.

Awesomium is dead. The last update was in 2015 and their website has dropped off the grid and if you go to it it's just a redirect to https://ultralig.ht/ (another Awesomium-like library). At the current point in time, we're on our own. Awesomium has no support and we currently have to downgrade all our sites that we want to use with it just to get it to work properly, like loading screens. This is a big restraint and holds back our creativity. If Garry's Mod keeps using Awesomium, there's going to be a lot of issues when the next generation of websites come rolling in.

I want CEF as soon as possible, and I think many people can agree with me on that statement.

@Fafy2801
Copy link

@Fafy2801 Fafy2801 commented Sep 19, 2018

keemstar

Garry will change his mind when YouTube ceases to work entirely.

This person predicted the future; YouTube does not work anymore

@WinterPhoenix
Copy link

@WinterPhoenix WinterPhoenix commented Sep 19, 2018

It looks like YouTube is either tossing out their VP8 360p video encodes, or making it so sufficiently old browsers (ex. Awesomium) can no longer play them. At the same time, they appear to be replacing all their VP9 encodes with AVC1 (an H.264 container).

What this means is:

  • Awesomium is no longer able to play YouTube at all, not even in 360p.
  • Chromium seems to still be able to play videos that have a VP8 360p encode, but no higher resolutions.

This change is probably related to the upcoming WebM AV1 codec, the successor to VP9. Like VP9, AV1 is expected to be used for high resolution YouTube videos, but unlike VP9, it has much much more support beyond just Google, including Netflix, Twitch, and chip vendors like Intel and AMD.

So, this is probably ultimately a good thing, once YouTube gets around to re-encoding things with AV1, Chromium/Chrome version 70 is out (in a month, and even then AV1 will still be behind a dev flag), GMod has at least that version of Chromium, and Chromium is on the Main Branch.

But until then, at the very least this makes it so the Main Branch is no longer capable of playing YouTube videos.

Please Willox, keep up the good work with the 64-bit branch so we can stop having to tell players to switch branches soon.

Also yes, Google dumped VP9 before their own browser even supports AV1, while also throwing browsers unable to play H.264 (probably temporarily) under the bus for HD.

@LewisTehMinerz
Copy link

@LewisTehMinerz LewisTehMinerz commented Sep 19, 2018

press ❤️ to pay respects to media player

@Rusketh
Copy link

@Rusketh Rusketh commented Nov 4, 2018

Just done a load of work with html and java script for some GUI's, turns out GarrysMod is not update enough to display them correctly. Can we please get this updated.

@LewisTehMinerz
Copy link

@LewisTehMinerz LewisTehMinerz commented Nov 4, 2018

👀

@chelog
Copy link

@chelog chelog commented May 31, 2019

Almost 4 years from this issue created and still no sign of Chromium on main branch. This cannot be serious, guys. It's pretty stable now to replace Awesomium. Even if Chromium now has some bugs or incompletes in gmod, it'd be MUCH more useful than having this old broken thing in the game. Start pushing it to main, please

@VaasKahnGrim
Copy link

@VaasKahnGrim VaasKahnGrim commented May 31, 2019

is there by chance a trello page or something similar that facepunch uses for these types of things? Would help in knowing how far along features like this are

@Bo98
Copy link

@Bo98 Bo98 commented May 31, 2019

Unfortunately not. The status of it now is that development is taking place on the 64-bit branch. This move was essential in order for Chromium to be supported on all platforms, which is not currently the case on the Chromium branch.

How far away is it? I honestly don't know, but it's one of the main focuses.

For the 32-bit Chromium branch, I wouldn't expect much further development there.

@WinterPhoenix
Copy link

@WinterPhoenix WinterPhoenix commented May 31, 2019

macOS still isn't supported on the 64-bit branch and that needs to be done before they can push it to main.

@Bo98
Copy link

@Bo98 Bo98 commented May 31, 2019

Yep, that's what's being worked on just now.

@chelog
Copy link

@chelog chelog commented Jun 1, 2019

@Noiwex actually it crashes only when being used :/

People who are on chromium branch do not crash at all in my servers (the ones that don't utilize chromium), however yes, when used, it does crash (which by the way didn't happen at all until recent update like around 2 weeks ago). Oh cmon, half of gmod servers already crashing clients by things that are in master branch for a long time

@WinterPhoenix
Copy link

@WinterPhoenix WinterPhoenix commented Jun 1, 2019

Hot take:
Creating issues for crash dumps including any information about what was going on when the crash took place helps the Facepunch developers identify and fix them, so they don't happen anymore.

They don't magically go away if they don't know what to look for and fix. Players have to give them that information.

@Sophie-bear
Copy link

@Sophie-bear Sophie-bear commented Jun 1, 2019

People on Windows should probably be using the x86-x64 branch for Chromium support rather than the Chromium branch anyway, at this point. See if they experience the same crashes on there.

@owltaver
Copy link

@owltaver owltaver commented Jun 30, 2019

With such a speed of developmen, it seems to me by the time when the framework is beeing updated, it will be outdated like awesomium.) Already, it looks old against the new versions of chromium, most types of playback are not supported. We can forget about mp4 and new streaming format witсh used on youtube and some new services. So yeah, i just hope chromium will be upgraded to a newer version at least after it comes out of beta. Otherwise, sense of this update will be quite a bit.

3oGQV58

@WinterPhoenix
Copy link

@WinterPhoenix WinterPhoenix commented Jun 30, 2019

Chromium will not support Proprietary Codecs in GMod no matter the version. Licensing them is an issue for Facepunch.

However, Solstice Game Studios and I have made a workaround for that.

Introducing GModCEFCodecFix:
https://github.com/solsticegamestudios/GModCEFCodecFix/

Knockout Thread:
https://knockout.chat/thread/1267/

@owltaver
Copy link

@owltaver owltaver commented Jun 30, 2019

Chromium will not support Proprietary Codecs in GMod no matter the version. Licensing them is an issue for Facepunch.

However, Solstice Game Studios and I have made a workaround for that.

Introducing GModCEFCodecFix:
https://github.com/solsticegamestudios/GModCEFCodecFix/

Wow, now i know. Thank you for that!

P.S. I'll hope devs slove licensing issue, that wouldn't be bad.

@benrob0329
Copy link

@benrob0329 benrob0329 commented Jul 1, 2019

Doesn't YouTube support VP8/9 though (at least for some videos)?

@WinterPhoenix
Copy link

@WinterPhoenix WinterPhoenix commented Jul 1, 2019

Doesn't YouTube support VP8/9 though (at least for some videos)?

It supports VP9 for most videos except those that are/were Live.

VP8 was dropped around September 2018 which made everything on YouTube stop working on Awesomium. Scroll up for more info on that.

Nearly every other video service uses H.264 (MP4) in some way, however, even Twitch. Which is why proprietary codecs are still an issue.

@AnthonyDMolnar
Copy link

@AnthonyDMolnar AnthonyDMolnar commented Sep 6, 2019

I tried to download the latest branch at defender flagged it as a virus and will not allow it to be downloaded. Anyone have an explanation on that?

@VaasKahnGrim
Copy link

@VaasKahnGrim VaasKahnGrim commented Sep 6, 2019

I tried to download the latest branch at defender flagged it as a virus and will not allow it to be downloaded. Anyone have an explanation on that?

Disable Windows Defender Bloatware

@AnthonyDMolnar
Copy link

@AnthonyDMolnar AnthonyDMolnar commented Sep 6, 2019

While I support the idea, it seems like a pretty big risk to do that. What is in there that is flagging it as a virus?

@VaasKahnGrim
Copy link

@VaasKahnGrim VaasKahnGrim commented Sep 6, 2019

I had a similar issue with an old antivirus called Avast! it had been flagging html stuff for garrysmod as malicious. it could be something similar

@AnthonyDMolnar
Copy link

@AnthonyDMolnar AnthonyDMolnar commented Sep 6, 2019

Okay, that makes some sense. I'm currently waiting out my chat delay timer on Solstice's discord so I can inquire more about the details from one of the developers. I do other coding work and I need to be cautious about any virus flags. I find it odd because I've downloaded tons of HTML based work from Git before and never had this issue.

@Sophie-bear
Copy link

@Sophie-bear Sophie-bear commented Sep 6, 2019

The official answer from WinterPhoenix about our "GMod CEF Codec Fix" tripping AV's:
"It trips heuristics because it does things that are "suspicious," like downloading files from the internet and then overwriting existing files.
The source code is available if you want to review it, but you'll see it doesn't do anything other than what's it's described to do."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet