Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new VGUI browser panel using ISteamHTMLSurface API #791

Closed
samuelmaddock opened this issue Jul 24, 2016 · 37 comments
Closed

Add new VGUI browser panel using ISteamHTMLSurface API #791

samuelmaddock opened this issue Jul 24, 2016 · 37 comments

Comments

@samuelmaddock
Copy link

@samuelmaddock samuelmaddock commented Jul 24, 2016

Instead of replacing Awesomium, add an additional VGUI panel using the ISteamHTMLSurface API. Some benefits include:

  • Evergreen browser; Steam will continue updating their underlying version of CEF
  • Alleviates outdated browser issues in addons using streaming services
  • Includes codecs for MP4 playback as well as DRM support (no licensing required)
  • Binaries already included with Steam for all platforms
  • No need to update existing game features (menu, third-party libraries, etc.)
  • No need to match existing DHTML API since this would be a new VGUI panel

Hopefully this could be a viable alternative to replacing Awesomium as previously rejected in #531. I haven't followed the issues regarding OS X 32-bit support with CEF, so I'm unsure if that would also be an issue here.

@samuelmaddock
Copy link
Author

@samuelmaddock samuelmaddock commented Aug 15, 2016

I recently found that Source SDK 2013 contains an updated HTML VGUI panel which uses the ISteamHTMLSurface API. Is it be possible to integrate these changes into GMod? @willox @robotboy655

@Digiquo
Copy link

@Digiquo Digiquo commented Aug 16, 2016

I'm here to help stop my favorite Gmod mode from dying (Cinema) and to support the longevity of Gmod in the long run. #replaceawesomium

@DemonAura
Copy link

@DemonAura DemonAura commented Aug 16, 2016

+1 The longer this goes on, the worse it gets. Awesomium is incredibly outdated and needs to be put to rest in favor of a more capable framework.

@Sophie-bear
Copy link

@Sophie-bear Sophie-bear commented Aug 16, 2016

Great idea, Sam. Hopefully this won't be shot down because it's very important to a lot of people and could bring about a lot of changes for the better.

@gonzalologorg
Copy link

@gonzalologorg gonzalologorg commented Aug 16, 2016

I never played cinema and possibly i will never play, but this guy...Deserves this...I don't want something that cool to die

@jasmin12e
Copy link

@jasmin12e jasmin12e commented Aug 16, 2016

+1 Please don't let things get worse I really enjoy cinema servers but everything needs an overhaul!

@SunsetsAndSushi
Copy link

@SunsetsAndSushi SunsetsAndSushi commented Aug 16, 2016

+1 Don't let Cinema die. Let's all make Gmod better.

@ghost
Copy link

@ghost ghost commented Aug 16, 2016

This issue has gone on way too long, and this looks to be a sound alternative if nothing else in the efforts to leave Awesomium's curse...

@WinterPhoenix
Copy link

@WinterPhoenix WinterPhoenix commented Aug 16, 2016

Once again, what we are suggesting is not that this VGUI Panel replace Awesomium, especially since Garry seems very against that idea, but an alternative, implemented separately to Awesomium, that GMod developers could work with. It would be completely optional.

@ghost
Copy link

@ghost ghost commented Aug 16, 2016

+1 But if someone actually manages to implement this as a pull request (which i don't think anyone could besides the gmod devs since its core files) that would be pretty cool :P

@cannon
Copy link

@cannon cannon commented Aug 17, 2016

@ghost
Copy link

@ghost ghost commented Aug 18, 2016

@willox
Copy link
Contributor

@willox willox commented Aug 18, 2016

We're not against the idea, but don't expect it for the next update. Asking people to post non-useful responses to any issues here isn't going to do much. Use the forums for that.

@WinterPhoenix
Copy link

@WinterPhoenix WinterPhoenix commented Aug 19, 2016

I'm genuinely glad to hear that, at the very least, you're not against the idea. If you can, please keep us posted. Thanks!

@El13B
Copy link

@El13B El13B commented Aug 26, 2016

I'm here to support Winter ^^ good luck Winter!

@JustinCase224
Copy link

@JustinCase224 JustinCase224 commented Aug 30, 2016

So what you mean is update the interface on the game, if so im rooting for ya

@Kamshak
Copy link

@Kamshak Kamshak commented Oct 25, 2016

Any news on this? Is there like a roadmap or something? Would be amazing to see this implemented, also as it is the most "Thumbed up" issue in here.

@literally-a-ninja
Copy link

@literally-a-ninja literally-a-ninja commented Nov 17, 2016

You guys have all my support.

@60percentCaffeine
Copy link

@60percentCaffeine 60percentCaffeine commented Nov 17, 2016

6 months since this request was born. [sarcasm]Unfortunately not 1 year. Hope it will stay unimplemented for at least 6 months more, so I can say "Happy Birthday!".[/sarcasm]

@WinterPhoenix
Copy link

@WinterPhoenix WinterPhoenix commented Dec 5, 2016

Two video services have now broken in the last month that were previously supported in Cinema and Media Player. They were Vimeo and Twitch, and both are no longer supported due to Awesomium's lack of newer JavaScript and HTML5 functionality.

Furthermore, Google Chrome is now (as of version 55, rolling out as of December 2nd) officially shipping Flash Player disabled by default, which will only expedite the process of the web as a whole abandoning Adobe Flash Player in favor of HTML5.

To be frank, Cinema and Media Player are looking to flat out lose support for all their video services very soon if this issue is not addressed. At the time of writing, this is the Most Thumbed Up Request on this GitHub Repo, with second place, #745, having 40 less, so why has it not been treated as a priority all this time?

@willox , @robotboy655 , for the love of god please implement this. It is time.

Thank you.

@60percentCaffeine
Copy link

@60percentCaffeine 60percentCaffeine commented Dec 5, 2016

@WinterPhoenix96 Don't worry, they will try to do something when Cinema dies completely.

@cannon
Copy link

@cannon cannon commented Dec 5, 2016

Let's do a binary add-on, lol.

@DoomandGloom
Copy link

@DoomandGloom DoomandGloom commented Dec 9, 2016

I just hope the gmod devs see how passionate we are about the cinema game mode and how much creativity and effort that goes into each server and what effect it would have on our communities when/if it dies out.

Thank you for raising these discussions and I hope a future solution comes.

@samuelmaddock
Copy link
Author

@samuelmaddock samuelmaddock commented Jan 3, 2017

I think it's worth reiterating that the intention of this request is to add a new browser VGUI control rather than replacing Awesomium. The ISteamHTMLSurface API isn't 100% compatible with the functionality Awesomium provides. To name a few incompatibilies: 1. no callbacks for console logged messages 2. no support for binding to JavaScript functions. These features would require work on behalf of Valve.

Getting rid of Awesomium would be nice—ISteamHTMLSurface API might not fit the requirements to replace it though.

@literally-a-ninja
Copy link

@literally-a-ninja literally-a-ninja commented Jan 4, 2017

CEF does not work on Mac. Then again, why not force Mac users to stay with Awesomium and the rest of us use CEF?

@Bo98
Copy link

@Bo98 Bo98 commented Jan 4, 2017

Older OS versions are also a problem.

@Bo98
Copy link

@Bo98 Bo98 commented Jan 4, 2017

Rust still runs in DX9 fine afaik. The option to force DX9 is even still there.

@60percentCaffeine
Copy link

@60percentCaffeine 60percentCaffeine commented Jan 7, 2017

@Noiwex I remember playing vanilla TTT totally fine on Linux for 3 hours without any crashes.

@Zenshu
Copy link

@Zenshu Zenshu commented Jan 28, 2017

sooo... news?

@Adam759
Copy link

@Adam759 Adam759 commented Feb 6, 2017

This is so ridiculous that something so crucial with Garrysmod is just being ignored and pushed aside. I wish they cared more to actually listen.

@willox
Copy link
Contributor

@willox willox commented Feb 6, 2017

This can't happen because browsers created with the ISteamHTMLSurface interface seem to share their session with the Steam Overlay's browser.

@willox willox closed this Feb 6, 2017
@cannon
Copy link

@cannon cannon commented Feb 6, 2017

So pages created on steamcommunity.com have the user's login and are vulnerable to extreme XSS? Understandable, but we still need a new embedded browser one way or another.

@Cloudwalk9
Copy link

@Cloudwalk9 Cloudwalk9 commented Feb 6, 2017

@Noiwex I might be wrong, but the crashing every 10 minutes may have something to do with OpenGL. It has limitations with 32-bit, with how it handles texture memory (3.5 GB limit).

I've noticed that setting the game to lower graphics settings significantly reduces the incidence of crashes and observing VRAM usage, Garry's Mod appears to crash when the 3.5 GB mark is reached.

Probably no way to fix that unless Garry's Mod switches to 64 bit, which might not be feasible.

@cannon
Copy link

@cannon cannon commented Feb 12, 2017

I mean... you could do something like blacklisting RunJavascript on steam* domains.

@minecrafter2334
Copy link

@minecrafter2334 minecrafter2334 commented Jul 17, 2018

All i want to do is use mediaplayer on mac

@ZokeysEPN
Copy link

@ZokeysEPN ZokeysEPN commented May 4, 2020

This is getting annoying, please fix it!

@WinterPhoenix
Copy link

@WinterPhoenix WinterPhoenix commented May 4, 2020

Please see this issue for more up to date discussion: #531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet