New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check if player is alive when testing players #1073

Merged
merged 1 commit into from Oct 29, 2016

Conversation

Projects
None yet
6 participants
@morfin60
Contributor

morfin60 commented Oct 5, 2015

Added check to ignore ghosts when testing(they could trigger false positive result)

Added check if player is alive when testing players
Added check to ignore ghosts when testing(they could trigger false positive result)
@Bo98

This comment has been minimized.

Contributor

Bo98 commented Oct 5, 2015

Doesn't ply:IsActiveTraitor() cover that?

@svdm

This comment has been minimized.

Collaborator

svdm commented Oct 5, 2015

Indeed, players are moved to the spectator team as soon as they die, and IsActiveTraitor will return false for anyone in that team. Is there a reproducible case where the entity gives a false positive?

@robotboy655 robotboy655 added the TTT label Oct 5, 2015

@BlackCetha

This comment has been minimized.

Contributor

BlackCetha commented Oct 5, 2015

Because he said "ghosts" ill guess its something with the spec-dm.

@Kefta

This comment has been minimized.

Contributor

Kefta commented Oct 5, 2015

Then that's something addon specific and should be handled within the addon

@morfin60

This comment has been minimized.

Contributor

morfin60 commented Oct 5, 2015

And there is a little problem. Guy i asked to go in tester was not in DM(he was just flying ghost), also i saw that problem on another server without ghosts DM(russian server)

@BlackCetha

This comment has been minimized.

Contributor

BlackCetha commented Oct 7, 2015

Give us steps to reproduce the problem so we can see whats going wrong please.
Also, what is a "flying ghost"? Do you mean a dead player in spectator mode?

@svdm svdm merged commit f72f6eb into Facepunch:master Oct 29, 2016

@morfin60

This comment has been minimized.

Contributor

morfin60 commented Nov 3, 2016

It was not flying ghost - it was walking ghost with gun in ghost DM which is like in special team but TTT traitor tester code see you're a T and not dead => shows red result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment