Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAlternative logging options #68
Merged
Conversation
|
This looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
3lpsy commentedOct 5, 2019
This PR adds an environment called "USE_NATIVE_LOGGER". When present, the log method will use native logging instead of print. This is to maintain compatibility when current workflows but also esolve this issue: FactionC2/Faction#35
I also added an alternative logging.conf with generic options and a more verbose level to docker_build. This file is more or less ignored but can be mounted as a volume in docker if you wish to increase logging and avoid using json.
Finally, I also added slightly better error reporting for when the API cannot connect to MQ. This makes it so you can identify network issues easier.