Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FD-654 Add CORS and update many libraries #598

Merged

Conversation

Projects
None yet
4 participants
@carryforward
Copy link
Contributor

carryforward commented Oct 18, 2018

This code was created by @PaulBernier even though it is showing as being merged in by JoshuaBrigati.

The glide.yaml was fixed to include the CORS library, as well as freshly recreating the dependent repos based on th current state of the codebase. The glide.lock file also includes a year of updates from libraries factomd uses.

Thank you Luap for writing this code to allow javascript browser access to the factomd API, and for the patience waiting for the patch to work its way to production.

JoshuaBrigati and others added some commits Sep 14, 2018

@PaulBernier

This comment has been minimized.

Copy link
Contributor

PaulBernier commented Oct 18, 2018

Thanks for reviewing my PR and considering merging it! I did a quick sanity check and it seems in order.

@factom-clay factom-clay merged commit d2c1194 into FD-706_release_candidate_6.0.2_dev Oct 20, 2018

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: coveralls Your tests passed on CircleCI!
Details
ci/circleci: docker_build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
coverage/coveralls First build on FD-654_adding_CORS_CLA_merge at 44.747%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.