New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SubFactory support for MongoEngine's EmbeddedDocument #100

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@imiric

imiric commented Oct 16, 2013

Hi,

I added the ability to use MongoEngineFactory for EmbeddedDocuments as well. I find it useful to define them as standard factories and just use SubFactory to create them.

Hope you find this useful.

Ivan

@rbarrois

This comment has been minimized.

Show comment
Hide comment
@rbarrois

rbarrois Oct 28, 2013

Member

Hi,

I'm not familiar with MongoEngine; but wouldn't it be more explicit to have a separate MongoEngineEmbeddedFactory class for EmbeddedDocument?

Member

rbarrois commented Oct 28, 2013

Hi,

I'm not familiar with MongoEngine; but wouldn't it be more explicit to have a separate MongoEngineEmbeddedFactory class for EmbeddedDocument?

@imiric

This comment has been minimized.

Show comment
Hide comment
@imiric

imiric Oct 29, 2013

That could be an alternative, but I prefer this simpler approach of not having to think about which document is embedded and which not.

Perhaps we could have @jtushman chime in with his opinion, as he submitted the original MongoEngine support PR.

imiric commented Oct 29, 2013

That could be an alternative, but I prefer this simpler approach of not having to think about which document is embedded and which not.

Perhaps we could have @jtushman chime in with his opinion, as he submitted the original MongoEngine support PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment