Removed duplicate SQLAlchemyModelFactory. #83

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@hartror

hartror commented Aug 27, 2013

There is a duplicate and outdated SQLAlchemyModelFactory at the bottom of factory/base.py the removal of which appears to have been missed when it was moved into a new file.

@rbarrois

This comment has been minimized.

Show comment
Hide comment
@rbarrois

rbarrois Aug 27, 2013

Member

Hmm, I should have been more careful :/

Thanks for the PR, but I can't merge it as is, since you've added other changes too.

Member

rbarrois commented Aug 27, 2013

Hmm, I should have been more careful :/

Thanks for the PR, but I can't merge it as is, since you've added other changes too.

@rbarrois rbarrois closed this in 7fc3e4c Aug 27, 2013

@hartror

This comment has been minimized.

Show comment
Hide comment
@hartror

hartror Aug 27, 2013

That's annoying should have done that on a branch.

Thanks.

hartror commented Aug 27, 2013

That's annoying should have done that on a branch.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment