New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate SQLAlchemyModelFactory. #83

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@hartror

hartror commented Aug 27, 2013

There is a duplicate and outdated SQLAlchemyModelFactory at the bottom of factory/base.py the removal of which appears to have been missed when it was moved into a new file.

@rbarrois

This comment has been minimized.

Member

rbarrois commented Aug 27, 2013

Hmm, I should have been more careful :/

Thanks for the PR, but I can't merge it as is, since you've added other changes too.

@rbarrois rbarrois closed this in 7fc3e4c Aug 27, 2013

@hartror

This comment has been minimized.

hartror commented Aug 27, 2013

That's annoying should have done that on a branch.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment