Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Listbox and Parameter Sentence component #159

Merged
merged 19 commits into from May 14, 2019

Conversation

Projects
None yet
3 participants
@korbinancell
Copy link
Collaborator

commented May 6, 2019

@korbinancell korbinancell requested a review from bryanrsmith May 6, 2019

@korbinancell

This comment has been minimized.

Copy link
Collaborator Author

commented May 6, 2019

The build is failing because it doesn't have access to @faithlife/command-sentence-control

1:42:54 PM: error An unexpected error occurred: "http://npm.faithlife.io/@faithlife%2fcommand-sentence-control/-/command-sentence-control-1.0.4.tgz: getaddrinfo ENOTFOUND npm.faithlife.io npm.faithlife.io:80".

@korbinancell korbinancell marked this pull request as ready for review May 7, 2019

@korbinancell

This comment has been minimized.

Copy link
Collaborator Author

commented May 7, 2019

I removed the dependency on command-sentence-control and added documentation on how to use the two.

@korbinancell korbinancell added the WIP label May 8, 2019

@bryanrsmith
Copy link
Collaborator

left a comment

lgtm 👍

Show resolved Hide resolved components/dropdown/dropdown-toggle-core.jsx Outdated
Show resolved Hide resolved components/listbox/list-item.jsx Outdated
Show resolved Hide resolved components/parameter-sentence/parameter-select.jsx Outdated

@korbinancell korbinancell removed the WIP label May 13, 2019

@korbinancell korbinancell merged commit 19e890a into Faithlife:master May 14, 2019

1 check passed

netlify/faithlife-styled-ui/deploy-preview Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.