Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply classname to button, not content. #160

Merged
merged 2 commits into from May 7, 2019

Conversation

Projects
None yet
2 participants
@korbinancell
Copy link
Collaborator

commented May 7, 2019

No description provided.

@@ -19,4 +19,6 @@ AnchorButton.propTypes = {
...BaseButton.propTypes,
/** The destination the AnchorButton should link to. */
href: PropTypes.string,
/** See the docs for how to override styles properly */

This comment has been minimized.

Copy link
@bryanrsmith

bryanrsmith May 7, 2019

Collaborator

Won't this comment appear in the docs? I think accurately describing the prop would be better than telling the reader to go away.

This comment has been minimized.

Copy link
@korbinancell

korbinancell May 7, 2019

Author Collaborator

I think that's a direct copy-paste from react-strap and we don't even have any docs on it

@korbinancell

This comment has been minimized.

Copy link
Collaborator Author

commented May 7, 2019

Looks like the button documentation is having issues as well. I'm looking into it.

@korbinancell

This comment has been minimized.

Copy link
Collaborator Author

commented May 7, 2019

The current version of babel-react-docgen cannot handle React.forwardRef and pretty much anything that is not a class component. Unfortunately, the next version requires Babel v7 which is a task in itself. #135 includes an upgrade to v7 so I will look into it when I get the time.

@korbinancell

This comment has been minimized.

Copy link
Collaborator Author

commented May 7, 2019

@bryanrsmith this is ready for review/merge

@bryanrsmith bryanrsmith merged commit 2030300 into Faithlife:master May 7, 2019

1 check passed

netlify/faithlife-styled-ui/deploy-preview Deploy preview ready!
Details

@korbinancell korbinancell deleted the korbinancell:button-fix branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.