Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button refactor #185

Merged
merged 17 commits into from Jul 10, 2019

Conversation

Projects
None yet
2 participants
@smaxa20
Copy link
Contributor

commented Jun 25, 2019

No description provided.

@smaxa20

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

Using the React.forwardRef function to forward the refs to AnchorButton and Button breaks the documentation for those components because our Babel isn't up to date enough to support that function. Updating Babel will come in a different PR by Bryan, but until then don't merge this.

Show resolved Hide resolved components/button/anchor-button.jsx Outdated
Show resolved Hide resolved components/button/anchor-button.jsx
Show resolved Hide resolved components/button/component.jsx Outdated
Show resolved Hide resolved components/button/styled.jsx Outdated

@bryanrsmith bryanrsmith merged commit 9b4bf6d into Faithlife:master Jul 10, 2019

1 check passed

netlify/faithlife-styled-ui/deploy-preview Deploy preview ready!
Details

@smaxa20 smaxa20 deleted the smaxa20:button-refactor branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.