Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequenced Tab Navigation #193

Merged
merged 31 commits into from Jul 18, 2019

Conversation

Projects
None yet
3 participants
@smaxa20
Copy link
Contributor

commented Jul 9, 2019

Show resolved Hide resolved catalog/index.js Outdated
Show resolved Hide resolved components/tabs/styled.jsx Outdated
Show resolved Hide resolved components/tabs/styled.jsx Outdated
Show resolved Hide resolved components/tabs/styled.jsx Outdated
Show resolved Hide resolved components/tabs/styled.jsx Outdated
Show resolved Hide resolved components/tabs/tab-helpers.jsx Outdated
Show resolved Hide resolved components/tabs/tab-helpers.jsx
Show resolved Hide resolved components/tabs/tab-helpers.jsx Outdated
Show resolved Hide resolved components/tabs/styled.jsx Outdated
Show resolved Hide resolved components/tabs/tab.jsx Outdated

smaxa20 added some commits Jul 9, 2019

Show resolved Hide resolved components/tabs/tab.jsx Outdated

smaxa20 added some commits Jul 10, 2019

@bryanrsmith

This comment has been minimized.

Copy link
Collaborator

commented Jul 18, 2019

@smaxa20 Could you take a look at the conflict in package.json? This looks great to me & I'm happy to merge it as soon as there's a green button for me to click :-)

@smaxa20

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

@bryanrsmith the only difference is whether or not the caret prefix appears before the focus-visible version number. I think it makes sense to keep it updated on minor versions, but I defer that decision to you.

@bryanrsmith

This comment has been minimized.

Copy link
Collaborator

commented Jul 18, 2019

Locking the version by omitting the caret is usually done deliberately to avoid an update that contains a bug or conflict in the dependency tree. I think you added that one, so if that's not the case here let's go ahead and change it to a caret range.

@smaxa20

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

Great. Ready to merge.

@bryanrsmith bryanrsmith merged commit d6bf3a9 into Faithlife:master Jul 18, 2019

1 check was pending

netlify/faithlife-styled-ui/deploy-preview Deploy preview processing.
Details

@smaxa20 smaxa20 deleted the smaxa20:sequenced-tab-navigation branch Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.