Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use a standard license #79

Closed
justinmchase opened this Issue Mar 6, 2013 · 10 comments

Comments

Projects
None yet
3 participants

I work for Microsoft and here we have a policy where we have to have LCA review the license for open source libraries before we can use that tool internally. However we also have a list of licenses that are pre-approved (such as GPL3 or MIT) where we don't have to have LCA review it, and we simply notify them of usage instead. I'm sure other companies have similar policies.

Your license appears to be a not-quite-gpl3 license. As such I could go to lca start up a discussion with someone jump through some hoops and have them check it out and approve it (which they probably would do) but the extra friction can be enough to turn some people off, especially when other tools have pre-approved licenses (e.g. NSubstitute).

So this is more of a recommendation than a bug, but I would like to propose that you change the license to fully match one of the standard licenses without anything custom added to it. It might help with adoption.

Member

patrik-hagne commented Mar 7, 2013

I don't know very much about licensing and I really don't know how to go about chaning the license? It wouldn't be a problem to change to a more "forgiving" license right? I guess MIT would be fine, I'd be happy to change to that. Also, I thought we were using a standard licens but as I said, I don't know much about it.

Owner

adamralph commented Mar 7, 2013

@patrik-hagne it should be just a case of committing a new license.txt to the repo. The NuGet package metadata now points to it. I use the MIT license for all my other projects so I'm fine with that too.

@justinmchase here is the MIT license I am using for another of my projects. Would a FakeItEasy equivalent be pre-approved at MS? https://github.com/xbehave/xbehave.net/blob/master/license.txt

Member

patrik-hagne commented Mar 7, 2013

If it's that easy, let's do it. I don't even remember why I didn't chose MIT from the beginning and it seems like I've changed it once already, it used to have the Microsoft OS license: http://fakes.codeplex.com/

Yeah basically you just copy the full text of one of the common licenses into license.txt and it should be all good. Here is the official MIT license:
http://opensource.org/licenses/mit-license.php

And that site has copies of many other common ones if you prefer something else.

@ghost ghost assigned adamralph Mar 7, 2013

adamralph added a commit to adamralph/FakeItEasy that referenced this issue Mar 7, 2013

Owner

adamralph commented Mar 7, 2013

@patrik-hagne I've assigned the below pull request for you to review, i.e. check that you're happy with the <copyright holders> text

@justinmchase can you please confirm that https://github.com/adamralph/FakeItEasy/blob/359412f7f59b1fb66affa0ac86959db461aaf4cd/License.txt would indeed satisfy pre-approval at MS. I've left out the <year> since, by my understanding, it's not necessary. If MS require the <year> to be filled in then please let me know and I'll amend.

Looks perfect to me.

Actually it might be helpful to add this to the top "The MIT License (MIT)". Just so future readers know which it is easily.

Owner

adamralph commented Mar 7, 2013

Ah, of course! I did that for xBehave.net but completely forgot this time.

adamralph added a commit to adamralph/FakeItEasy that referenced this issue Mar 7, 2013

perfect.

patrik-hagne added a commit that referenced this issue Mar 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment