Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to improve error messages when overriding extension method or static #313

Merged
merged 1 commit into from May 27, 2014

Conversation

@Dashue
Copy link
Contributor

commented May 25, 2014

Fixes #274

{
canBeIntercepted = this.proxyGenerator.MethodCanBeInterceptedOnInstance(method, callTarget, out failReason);
}
catch (ArgumentNullException)

This comment has been minimized.

Copy link
@adamralph

adamralph May 26, 2014

Contributor

There should never be a reason to catch this exception type. We can examine whether callTarget is null before making the call.

However, I'm not convinced this is the best place to make the change. I'll leave a general comment on the PR regarding that.

@adamralph

This comment has been minimized.

Copy link
Contributor

commented May 26, 2014

Please see #274 (comment)

@adamralph adamralph self-assigned this May 26, 2014
@adamralph adamralph referenced this pull request May 26, 2014
@blairconrad blairconrad merged commit 2228af4 into FakeItEasy:master May 27, 2014
1 check passed
1 check passed
default Finished TeamCity Build FakeItEasy :: FakeItEasy : Tests passed: 1080, ignored: 1
Details
@Dashue Dashue deleted the Dashue:improve_error_msg_when_static branch Jun 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.