Issue480 #481
Merged
Issue480 #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @thomaslevesque. Generally looks good, I think, but I think we may be a while before we get other owners' eyes on it. One thing that I would suggest though, and maybe I'm being overly picky, is that the commit messages could be more descriptive. It's true that they are a test and fix for #480, but it'd be nice to have more context, such as what you provided for your commits in #471. We appreciate your input. |
A.CallTo throws a NullReferenceException when trying to configure a non-virtual generic method. It should throw a FakeConfigurationException, as it does for a non-virtual non-generic method. This commit just adds a test case to prove the issue.
The problem was in MethodInfoManager.HasSameBaseMethod. Apparently, for a virtual generic method, GetBaseMethod returns the generic definition (IsGenericMethodDefinition is true), but not for a non-virtual generic method (in this case it returns the realized method itself). This caused IsSameMethod to return false, which in turn caused GetInvokedMethod to return null, and this case was not handled in GetReasonForWhyMethodCanNotBeIntercepted. Fixed the issue by always calling GetGenericMethodDefinition on generic methods.
thomaslevesque
force-pushed
the
issue480
branch
from
4c76801
to
470c59f
Compare
|
I pushed the reworded commits |
adamralph
added a commit
that referenced
this pull request
Apr 28, 2015
|
Thanks @thomaslevesque! Look out for your name in the release notes 🏆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
HasSameBaseMethodto ensure we're always working with the generic method definitionfixes #480