766 settings usability improvements#794
Merged
Merged
Conversation
Member
|
How did you test the matches and restartRequired properties? No settings use matches or restartRequired? |
Contributor
Author
I made mock settings and deleted them afterwards. |
1Blademaster
reviewed
Nov 3, 2025
Contributor
Author
|
I did a lot of experimenting with different combinations, this is the least intrusive, most intuitive design I think. the modals broke flow. this is how VS Code implements their settings |
1Blademaster
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.