chore(ci): drop Qodana#11
Merged
Merged
Conversation
Removes the JetBrains Qodana static-analysis workflow and its artifacts. It has been failing on every run on this fork because the QODANA_TOKEN secret belonged to the previous maintainer's account. Files removed: - .github/workflows/code-quality.yml — the JetBrains/qodana-action job - qodana.yml — local Qodana config - qodana.sarif.json — 6.9MB baseline of suppressed findings from the previous maintainer's scans The security-scanning gap will be filled by CodeQL — see #8. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 18, 2026
This was referenced May 28, 2026
Closed
ChrisonSimtian
added a commit
that referenced
this pull request
May 28, 2026
…uth (#260) Removes the 4-line `// Copyright ... Maintainers of Fallout. // Originally based on NUKE ...` block from 614 first-party .cs files under src/, tests/, build/, and the repo root. MIT compliance is already satisfied at the top level: - LICENSE preserves "Maintainers of NUKE 2017-2025" (matkoch's attribution) alongside "Maintainers of Fallout 2026". - README acknowledges the NUKE origin and links upstream. - Every NuGet package declares MIT via PackageLicenseExpression in Directory.Build.props. Vendored third-party code keeps its own copyright headers untouched - files under src/Persistence/Fallout.Persistence.Solution/ retain Microsoft's MIT notice as required, and the .Generated.cs tool wrappers + Verify snapshots keep their auto-generated headers. Rationale: - One source of truth is easier to maintain than 614 copies. - The header URL "github.com/ChrisonSimtian/Fallout/blob/main/LICENSE" would have rotted across hundreds of files the moment the repo transfers to the Fallout-build org (#11). - Cleaner source files; things live where they belong. - Housekeeping aligned with the rebrand cleanup. Convention docs updated to match: - AGENTS.md rule #4 replaced with explicit no-headers rule - docs/agents/conventions.md license-header bullet rewritten - docs/architecture.md mandate replaced with "no per-file headers" - CONTRIBUTING.md "license headers are mechanical" aside dropped Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the JetBrains Qodana static-analysis workflow and its artifacts. It has been failing on every run on this fork because the `QODANA_TOKEN` secret belonged to the previous maintainer's account.
Stacked on #10 (trunk migration). Change base to develop/main once #10 is merged.
Files removed
The security-scanning gap will be filled by CodeQL — see #8.
Test plan
🤖 Generated with Claude Code