refactor(arch)!: Application ring — core API → Fallout.Application (onion step 2)#349
Closed
ChrisonSimtian wants to merge 4 commits into
Closed
refactor(arch)!: Application ring — core API → Fallout.Application (onion step 2)#349ChrisonSimtian wants to merge 4 commits into
ChrisonSimtian wants to merge 4 commits into
Conversation
ChrisonSimtian
added
breaking-change
Roslyn syntax tool for the ADR-0006 namespace moves: rewrites namespace decls in the source project + qualified refs to moved types, and fixes usings by type identity. Dry-run quantifies the Application ring: 91 moved types across ~392 files. Finding: syntactic reference-resolution is not precise enough for a clean apply — simple-name collisions across namespaces (e.g. lower layers like ProjectModel matching a moved type's name) cause spurious usings and risk CS0104 ambiguities. The namespace-decl + qualified-name passes are correct; the using fixup needs a semantic upgrade (MSBuildWorkspace + symbol resolution) before applying. Dry-run only; mutates nothing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ution) Resolves each reference by the symbol it binds to, so namespace moves are precise: no spurious usings, no CS0104. Opens csprojs individually (sidesteps .slnx). Drops only usings orphaned by the move (leaves pre-existing unused usings alone). Dry-run on the Application ring: 91 moved types, 238 files, 12 qualified refs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…onion step 2) ADR-0006 step 2, via the semantic OnionRewriter (MSBuildWorkspace + symbol resolution). Every type Fallout.Build declared under Fallout.Common.* (FalloutBuild, Target, [Parameter], Host, the ports, the execution engine, value injection) moves to Fallout.Application.*; references fixed repo-wide by the symbol each binds to. ~297 files; full solution builds and tests green (~450 tests, incl. Domain fitness). Tool refinements landed here: name-based moved-type classification (cross-project), package-consumer skip, attribute/extension-method detection, nested-type qualified refs, evacuated- vs surviving-namespace using reconciliation. Four dangling usings hand-finished; Verify snapshots (solution generator, cake-migration) updated. Deferred (ADR-0006): Nuke.* shim parity lapses — Nuke.Consumer + Nuke.Common.Shim.Tests temporarily excluded from the solution, to be re-addressed by the redesigned migration phase. Project-FILE rename (Fallout.Build dir/csproj -> Fallout.Application) still to do — namespaces are migrated; the assembly is renamed in a mechanical follow-up. BREAKING CHANGE: Fallout.Common.* core-API namespaces -> Fallout.Application.*. On experimental; batched to the 2026 major. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ChrisonSimtian
force-pushed
the
spike/onion-structure
branch
from
1fe9c10 to
498d150
Compare
ChrisonSimtian
force-pushed
the
spike/onion-application
branch
from
bc5fc77 to
4f29ae4
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 of the onion realignment (ADR-0006). Stacks on #343 (the Domain ring) — base is
spike/onion-structure, so this diff is just the Application ring.How
A purpose-built semantic rewriter (
tools/OnionRewriter, MSBuildWorkspace + symbol resolution) moves every typeFallout.Builddeclared underFallout.Common.*toFallout.Application.*and fixes references repo-wide by the symbol each binds to — so simple-name collisions across the sharedFallout.Commonroot resolve correctly (no spurious usings, noCS0104). ~297 files; 4usings hand-finished at the tail.Validation
Deferred (ADR-0006)
Nuke.*shim parity lapses — the Application ring moved the API the shim mirrors.Nuke.Consumer+Nuke.Common.Shim.Testsare temporarily excluded from the solution (commented infallout.slnx), to be re-addressed by the redesigned migration phase.Fallout.Builddir/csproj/assembly →Fallout.Application) is a later mechanical step — namespaces are already migrated.[Unreleased] — 2026.0.🤖 Generated with Claude Code