refactor(io)!: back FtpTasks with FluentFTP#365
Closed
ChrisonSimtian wants to merge 7 commits into
Closed
Conversation
…330) Implements the trigger/hygiene slice of milestone #18 (CI cost & pipeline structure). #325 (publish-lane realignment) already landed in the ladder PR. - #318/#326 Cross-platform gated to release intent. windows/macos no longer run on main/experimental pushes (or any routine push). They run only on PR-to- release/* or support/*, and on v* tag pushes. ("On main we've got our edge": the ubuntu-latest PR gate + alpha/preview pipelines.) workflow_dispatch is not emitted — the generator only writes it with inputs; GitHub's run re-run covers on-demand cross-platform. - #322 concurrency cancel-in-progress on ubuntu/windows/macos (generator) + experimental.yml + preview.yml. NOT on release.yml (never cancel a publish). - #323/#328 Canonical CI-ignore list (docs/**, .assets/**, **/*.md) on every PR/push trigger. (release.yml is tag-triggered, so path-ignore is N/A there.) - #327 Codified "feature branches run zero CI until PR'd" + the trigger model in docs/agents/conventions.md, with what-not-to-do guards. - #329 Dropped dead 'submodules: recursive' from all checkouts + the generator (no .gitmodules; full build passes without it) and the stale vendor comment. Generated workflows regenerated from build/Build.CI.GitHubActions.cs. Deferred (own follow-ups): #324 split Build/Test/Pack stages; #328 caching deep-dive; #327 automated reflective guard-test (docs guard in place now). Also unblocked publishing separately: the github-packages environment deployment policy now allows experimental/main/release/*/support/* + v* tags. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…328) (#331) #324 — experimental.yml and preview.yml ran `dotnet fallout Pack` only, publishing alpha/preview packages WITHOUT running tests. Both now run `dotnet fallout Test Pack` (release.yml + the PR gate already did). One invocation = NUKE's discrete internal stages (Restore → Compile → Test → Pack), failing at the breaking stage; a test failure stops the job before the push step, so untested packages never publish. Separate per-step `dotnet fallout` invocations are avoided on purpose — each re-runs the dependency graph (double-compile); the single invocation is the staged build. #328 — added `restore-keys:` prefix fallback to the hand-written workflows' caches for faster partial restores on key miss. Evaluation: current key (global.json + *.csproj + Directory.Packages.props) is the right dependency set; no packages.lock.json exists to add; build-output (bin/obj) caching deliberately not done (stale-artifact risk). Canonical ignore list (docs/.assets/md) already applied in the trigger PR. Codified both in docs/agents/conventions.md. Deferred: #327 automated reflective guard-test (docs guard already in place). Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Repo moved ChrisonSimtian/Fallout → Fallout-build/Fallout. Owner-scoped refs that don't auto-redirect, fixed on main: - GitHub Packages feed URL nuget.pkg.github.com/ChrisonSimtian → /Fallout-build (release.yml, preview.yml, experimental.yml, + consumer docs: shim READMEs, from-nuke.md, release-and-versioning.md, CHANGELOG mention) - CODEOWNERS @ChrisonSimtian → @Fallout-build/maintainers (team now has Maintain access) Feed stays PAT-gated (GitHub Packages has no anonymous access even when public; #344). Web links / badges / issue refs redirect automatically and are left for a later sweep. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Updated star tracking links and attribution in README.
- Replace deprecated WebRequest/WebRequestMethods.Ftp upload path with the maintained, async-first FluentFTP client (AsyncFtpClient). - Remove the SYSLIB0014 suppression from FtpTasks. - Async-first API with sync wrappers (matches HttpTasks); methods now take an explicit host plus server-relative paths instead of full ftp:// URIs. Breaking public API change, lands on experimental. - Add FluentFTP 54.2.0 to Directory.Packages.props; reference it from Fallout.Common. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisonSimtian
added
breaking-change
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
WebRequest/WebRequestMethods.Ftpupload path inFtpTaskswith the maintained, async-first FluentFTP client (AsyncFtpClient).SYSLIB0014suppression fromFtpTasks.Directory.Packages.propsand reference it fromFallout.Common.Why
WebRequest-based FTP is obsolete (SYSLIB0014) and unmaintained.FtpTasksis public API. Signatures changed: methods are now async-first with sync wrappers (matchingHttpTasks) and take an explicithostplus server-relative paths instead of fullftp://URIs. Lands onexperimental, batched to the yearly major per ADR-0004.Migration:
FtpUploadFile(file, "ftp://host/path")->FtpUploadFile("host", file, "/path")(orFtpUploadFileAsync).FtpUploadDirectoryRecursively(dir, "ftp://host/root")->FtpUploadDirectoryRecursively("host", dir, "/root").FtpCredentials(staticNetworkCredential) is unchanged.Tests
dotnet build src/Fallout.Common/Fallout.Common.csproj— green (0 errors).dotnet test tests/Fallout.Common.Tests— 33 passed, 7 skipped. The one failure (GitHubTasksTest.GitHubRepositoryFromLocalDirectoryTest) is a pre-existing, environment-only artifact of running inside a.claude/worktreespath; it fails identically on the base branch and is unrelated to this change.Closes #354