From eab93a973ddb2fdb5ae06794129e19a653ffb8af Mon Sep 17 00:00:00 2001 From: Vasil Kotsev <9307969+SonnyRR@users.noreply.github.com> Date: Sat, 20 Jun 2026 15:04:15 +0300 Subject: [PATCH 1/2] Fix CS1734 warning in TransitionShimGenerator attribute XML doc MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The generated ShimAllPublicTypesUnderAttribute class has a XML doc comment that uses tags to reference constructor parameters. At the class level, can only reference type parameters (generic params), not constructor params — CS1734. Replace with inline code tags to resolve the warning without losing the semantic hint. --- src/Fallout.SourceGenerators/TransitionShimGenerator.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Fallout.SourceGenerators/TransitionShimGenerator.cs b/src/Fallout.SourceGenerators/TransitionShimGenerator.cs index ee277d6d9..a2eab8a93 100644 --- a/src/Fallout.SourceGenerators/TransitionShimGenerator.cs +++ b/src/Fallout.SourceGenerators/TransitionShimGenerator.cs @@ -670,8 +670,8 @@ namespace Fallout.Migrate.Shims; /// /// Marks the consuming assembly as a transition-shim project. The /// TransitionShimGenerator walks referenced Fallout.* assemblies and emits - /// shim types under mirroring the - /// public types whose namespace begins with . + /// shim types under toNamespacePrefix mirroring the + /// public types whose namespace begins with fromNamespacePrefix. /// [System.AttributeUsage(System.AttributeTargets.Assembly, AllowMultiple = true)] internal sealed class ShimAllPublicTypesUnderAttribute : System.Attribute From a4ebdec1922e277aae6bf7d2924ce84ae6c6986b Mon Sep 17 00:00:00 2001 From: Vasil Kotsev <9307969+SonnyRR@users.noreply.github.com> Date: Sat, 20 Jun 2026 21:06:21 +0300 Subject: [PATCH 2/2] Update Verify snapshot to match CS1734 XML doc fix Replace with in the ShimAllPublicTypesUnderAttribute generated XML doc to match the source generator change in eab93a97. --- ...ipsHardTier#ShimAllPublicTypesUnderAttribute.g.verified.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Fallout.SourceGenerators.Tests/TransitionShimGeneratorTest.EmitsShimsForEachKindAndSkipsHardTier#ShimAllPublicTypesUnderAttribute.g.verified.cs b/tests/Fallout.SourceGenerators.Tests/TransitionShimGeneratorTest.EmitsShimsForEachKindAndSkipsHardTier#ShimAllPublicTypesUnderAttribute.g.verified.cs index 997d07273..274831710 100644 --- a/tests/Fallout.SourceGenerators.Tests/TransitionShimGeneratorTest.EmitsShimsForEachKindAndSkipsHardTier#ShimAllPublicTypesUnderAttribute.g.verified.cs +++ b/tests/Fallout.SourceGenerators.Tests/TransitionShimGeneratorTest.EmitsShimsForEachKindAndSkipsHardTier#ShimAllPublicTypesUnderAttribute.g.verified.cs @@ -6,8 +6,8 @@ namespace Fallout.Migrate.Shims; /// /// Marks the consuming assembly as a transition-shim project. The /// TransitionShimGenerator walks referenced Fallout.* assemblies and emits -/// shim types under mirroring the -/// public types whose namespace begins with . +/// shim types under toNamespacePrefix mirroring the +/// public types whose namespace begins with fromNamespacePrefix. /// [System.AttributeUsage(System.AttributeTargets.Assembly, AllowMultiple = true)] internal sealed class ShimAllPublicTypesUnderAttribute : System.Attribute