Guard node.setSizeMode() against null values in "famous:core:node" #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a case where a behavior sends an event to node (ex:
size-absolute-x
) with$payload
being either actual size value ornull
depends on repeat$index
as follows:This PR adds
null
guards to all$public
events withinfamous:core:node
such that internally it does not updatenode.setSizeMode
with incorrect value when$payload === null
.