Skip to content

Commits

Permalink
rebase/m2r-sta…
Switch branches/tags

Name already in use

A tag already exists with the provided branch name. Many Git commands accept both tag and branch names, so creating this branch may cause unexpected behavior. Are you sure you want to create this branch?

Commits on Jan 20, 2015

  1. libxl: Add qxl vga interface support for upstream qemu

    Usage:
    vga="qxl"
    
    Qxl vga support many resolutions that not supported by stdvga,
    mainly the 16:9 ones and other high up to 2560x1600.
    With QXL you can get improved performance and smooth video also
    with high resolutions and high quality.
    Require their drivers installed in the domU and spice used
    otherwise act as a simple stdvga.
    
    Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
    Signed-off-by: Zhou Peng <zpengxen@gmail.com>
    Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
    
    ---
    
    Changes in v17:
    - refresh
    
    Changes in v16:
    - refresh
    - improved commit description
    
    Changes in v15:
    - refresh
    - small code improvements in libxl_dm.c
    
    Changes in v14:
    - refresh
    - update qemu parameters (from -vga to -device)
    
    NOTES:
    Works correctly with windows domUs, tested on windows 7 64 bit
    with qxl driver from spice guest tools 0.74.
    I tested some resolution not supported by stdvga (1366x768, 1600x900
    and 1920x1080) with 32 bit color and all works good equal to kvm.
    For now not works on linux domUs when xorg have 100% cpu and black
    screen with qxl driver installed.
    Seems needed other changes/fixes on xen and/or xorg/qxl driver side
    before have it full working with linux domUs.
    Fantu committed Jan 20, 2015
    Copy the full SHA
    0005cd8 View commit details
    Browse the repository at this point in the history
  2. tools: various things just for fast test build

    - Remove python prefix
    - Add/remove/stop of main services (xencommons, xendomains)
    
    NOTE:
    This patch is only for do fast test build with make debball
    and upstream qemu build with spice full features.
    
    Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
    
    ---
    
    Changes from v2:
    - remove add of spice and usbredir on upstream qemu build
    
    Changes from v1:
    - Added: Add/remove/stop of main services
    Fantu committed Jan 20, 2015
    Copy the full SHA
    9002389 View commit details
    Browse the repository at this point in the history
  3. libxl: Spice streaming video setting support for upstream qemu

    Usage:
    spice_streaming_video=[filter|all|off]
    
    Specifies what streaming video setting is to be used by spice (if
    given),
    otherwise the qemu default will be used.
    
    Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
    
    ---
    
    Changes in v4:
    - libxl_dm.c, cutted long line for coding style limit
    
    Changes in v3:
    - fixed a mistake in libxl_dm.c
    
    Changes in v2:
    - refresh
    Fantu committed Jan 20, 2015
    Copy the full SHA
    fc37241 View commit details
    Browse the repository at this point in the history
  4. libxl: Spice image compression setting support for upstream qemu

    Usage:
    spice_image_compression=[auto_glz|auto_lz|quic|glz|lz|off]
    
    Specifies what image compression is to be used by spice (if given),
    otherwise the qemu default will be used.
    
    Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
    
    ---
    
    Changes in v3:
    - improved description in xl.cfg.pod.5
    - libxl_dm.c, cutted long line for coding style limit
    
    Changes in v2:
    - refresh
    Fantu committed Jan 20, 2015
    Copy the full SHA
    d8a0bd6 View commit details
    Browse the repository at this point in the history
  5. x86/hvm: add per-vcpu evtchn upcalls

    HVM guests have always been confined to using the domain callback
    via (see HVM_PARAM_CALLBACK_IRQ) to receive event notifications.
    This is usually an IOAPIC vector and is only used if the event
    channel is bound to vcpu 0.
    
    PVHVM Linux uses a pre-defined interrupt vector for the event
    channel upcall, set using HVM_PARAM_CALLBACK_IRQ by ORing in a
    special bit (bit 57) into the value (see params.h). However, it
    does not assert the interrupt via the emulated local APIC.
    
    This mechanism is not suitable in the general case since Windows
    (and potentially other OSes) because they:
    
    - cannot guarantee the same vector for all VCPUs
    - do require the upcall to be asserted via the local APIC
    
    This patch adds a new HVM op allowing a guest to specify a local
    APIC vector to use as an upcall notification for a specific vcpu
    therefore coping with the case of differing vector numbers.
    
    Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
    Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Paul Durrant authored and Fantu committed Jan 20, 2015
    Copy the full SHA
    57ef3fd View commit details
    Browse the repository at this point in the history
  6. x86/hvm: extend HVM cpuid leaf with vcpu id

    To perform certain hypercalls HVM guests need to use Xen's idea of
    vcpu id, which may well not match the guest OS idea of CPU id.
    This patch adds vcpu id to the HVM cpuid leaf allowing the guest
    to build a mapping.
    
    Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
    Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Paul Durrant authored and Fantu committed Jan 20, 2015
    Copy the full SHA
    9878c24 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2015

  1. Revert "dpci: move from an hvm_irq_dpci (and struct domain) to an hvm…

    …_dirq_dpci model"
    
    This reverts commit aeeea48.
    
    As there are issues with huge amount of MSI-X going off.
    
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    konradwilk committed Jan 12, 2015
    Copy the full SHA
    a8ac229 View commit details
    Browse the repository at this point in the history
  2. Revert "dpci: replace tasklet with softirq"

    This reverts commit f6dd295.
    
    As there are issues with huge amount of MSI-X going off.
    
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    konradwilk committed Jan 12, 2015
    Copy the full SHA
    72f3c1e View commit details
    Browse the repository at this point in the history
  3. Revert "dpci: add 'masked' as a gate for hvm_dirq_assist to process"

    This reverts commit 104072f.
    
    As there are issues with huge amount of MSI-X going off.
    
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    konradwilk committed Jan 12, 2015
    Copy the full SHA
    1965728 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2015

  1. README: Expand to enumerate other toolstack features

    Reported-by: Pasi Kärkkäinen <pasik@iki.fi>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    konradwilk committed Jan 7, 2015
    Copy the full SHA
    3508d75 View commit details
    Browse the repository at this point in the history
  2. VT-d: don't crash when PTE bits 52 and up are non-zero

    This can (and will) be legitimately the case when sharing page tables
    with EPT (more of a problem before p2m_access_rwx became zero, but
    still possible even now when other than that is the default for a
    guest), leading to an unconditional crash (in print_vtd_entries())
    when a DMA remapping fault occurs.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Kevin Tian <kevin.tian@intel.com>
    Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    master commit: 46e0baf
    master date: 2015-01-07 11:13:58 +0100
    jbeulich committed Jan 7, 2015
    Copy the full SHA
    ad6f658 View commit details
    Browse the repository at this point in the history
  3. x86/VPMU: Clear last_vcpu when destroying VPMU

    We need to make sure that last_vcpu is not pointing to VCPU whose
    VPMU is being destroyed. Otherwise we may try to dereference it in
    the future, when VCPU is gone.
    
    We have to do this via IPI since otherwise there is a (somewheat
    theoretical) chance that between test and subsequent clearing
    of last_vcpu the remote processor (i.e. vpmu->last_pcpu) might do
    both vpmu_load() and then vpmu_save() for another VCPU. The former
    will clear last_vcpu and the latter will set it to something else.
    
    Performing this operation via IPI will guarantee that nothing can
    happen on the remote processor between testing and clearing of
    last_vcpu.
    
    We should also check for VPMU_CONTEXT_ALLOCATED in vpmu_destroy() to
    avoid unnecessary percpu tests and arch-specific destroy ops. Thus
    checks in AMD and Intel routines are no longer needed.
    
    Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
    Acked-by: Kevin Tian <kevin.tian@intel.com>
    Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    master commit: ed80171
    master date: 2015-01-07 11:12:27 +0100
    Boris Ostrovsky authored and jbeulich committed Jan 7, 2015
    Copy the full SHA
    31a4100 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2015

  1. README: Rewrap to 70 columns.

    The first paragraph seems to have been wrapped to 70, so do the other
    new paragraphs to 70 too for visual consistency.
    
    No non-whitespace change.
    
    Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
    CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    ijackson-citrix authored and konradwilk committed Jan 6, 2015
    Copy the full SHA
    babb790 View commit details
    Browse the repository at this point in the history
  2. README: Minor punctuation and grammar changes

    * Add two missing "and"s and a missing semicolon (a la Oxford comma).
    * Use a double-space after full stop (like the first paragraph does).
    
    Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
    CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    ijackson-citrix authored and konradwilk committed Jan 6, 2015
    Copy the full SHA
    59b572e View commit details
    Browse the repository at this point in the history
  3. README, xen/Makefile: Update to Xen 4.5.0

    Expand the README file to give a brief view of what went in
    Xen 4.5.0. Also change the Makefile to not use the '-rc'
    postfix.
    
    Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    konradwilk committed Jan 6, 2015
    Copy the full SHA
    0e766ea View commit details
    Browse the repository at this point in the history
  4. Config.mk: Update with proper QEMU tags for Xen 4.5.0 release

    The trees are tagged.
    
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    konradwilk committed Jan 6, 2015
    Copy the full SHA
    1260a99 View commit details
    Browse the repository at this point in the history
  5. Config.mk: Update cloned trees' urls to 4.5 repo (missing -testing)

    It was missing the the '-testing' postfix.
    
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    konradwilk committed Jan 6, 2015
    Copy the full SHA
    7ed671d View commit details
    Browse the repository at this point in the history
  6. Config.mk: Update cloned trees' urls to 4.5 repos

    These repos have branched for 4.5, along with xen.git.  At the moment,
    they have a repo per Xen branch.
    
    Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
    ijackson-citrix committed Jan 6, 2015
    Copy the full SHA
    e34fbb3 View commit details
    Browse the repository at this point in the history
  7. Config.mk: Non-debug build by default.

    Set debug ?= n, in preperation for releasing.
    
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    konradwilk committed Jan 6, 2015
    Copy the full SHA
    48a0b16 View commit details
    Browse the repository at this point in the history
  8. tools/hotplug: remove EnvironmentFile from xen-qemu-dom0-disk-backend…

    ….service
    
    The referenced Environment file does not exist, and the service file
    does not make use of variables anyway.
    
    N.B. If we start honouring env settings for any reason this will
    have to be changed.
    
    Signed-off-by: Olaf Hering <olaf@aepfle.de>
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Cc: Wei Liu <wei.liu2@citrix.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    olafhering authored and konradwilk committed Jan 6, 2015
    Copy the full SHA
    88ef4e4 View commit details
    Browse the repository at this point in the history
  9. tools/hotplug: use XENCONSOLED_TRACE in xenconsoled.service

    Instead of inventing a new XENCONSOLED_LOG= variable reuse the
    existing XENCONSOLED_TRACE= variable in xenconsoled.service.
    
    Signed-off-by: Olaf Hering <olaf@aepfle.de>
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Cc: Wei Liu <wei.liu2@citrix.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    olafhering authored and konradwilk committed Jan 6, 2015
    Copy the full SHA
    098f913 View commit details
    Browse the repository at this point in the history
  10. tools/hotplug: use xencommons as EnvironmentFile in xenconsoled.service

    The referenced sysconfig/xenconsoled does not exist. If anything
    needs to be specified it has to go into the existing
    sysconfig/xencommons file.
    
    Signed-off-by: Olaf Hering <olaf@aepfle.de>
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Cc: Wei Liu <wei.liu2@citrix.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    olafhering authored and konradwilk committed Jan 6, 2015
    Copy the full SHA
    9fd87d3 View commit details
    Browse the repository at this point in the history
  11. tools/hotplug: xendomains.service depends on network

    Starting domains during boot will most likely require network for
    the local bridge and it may need access to remote filesystems. Add
    ordering tags to systemd service file.
    
    Signed-off-by: Olaf Hering <olaf@aepfle.de>
    Acked-by: Wei Liu <wei.liu2@citrix.com>
    Cc: Ian Jackson <ian.jackson@eu.citrix.com>
    Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Cc: Ian Campbell <ian.campbell@citrix.com>
    Cc: Wei Liu <wei.liu2@citrix.com>
    Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    olafhering authored and konradwilk committed Jan 6, 2015
    Copy the full SHA
    37cc9d9 View commit details
    Browse the repository at this point in the history
  12. tools/hotplug: remove XENSTORED_ROOTDIR from xenstored.service

    There is no need to export XENSTORED_ROOTDIR. This variable can be
    enabled in sysconfig/xencommons. If the variable is unset xenstored
    will automatically use @XEN_LIB_STORED@.
    
    Signed-off-by: Olaf Hering <olaf@aepfle.de>
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    Cc: Ian Jackson <ian.jackson@eu.citrix.com>
    Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Cc: Ian Campbell <ian.campbell@citrix.com>
    Cc: Wei Liu <wei.liu2@citrix.com>
    Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    olafhering authored and konradwilk committed Jan 6, 2015
    Copy the full SHA
    ae978c5 View commit details
    Browse the repository at this point in the history
  13. tools/hotplug: remove SELinux options from var-lib-xenstored.mount

    Using SELinux mount options per default breaks several systems.
    Either the context= mount option is not known at all to the kernel,
    as reported for ArchLinux. Or the default value "none" is unknown to
    SELinux, as reported for Fedora. In both cases the unit will fail.
    
    The proper place to specify mount options is /etc/fstab. Apparently
    systemd is kind enough to use values from there even if Options= or
    What= is specified in a .mount file.
    
    Remove XENSTORED_MOUNT_CTX, the reference to a non-existent
    EnvironmentFile and trim default Options= for the mount point.
    
    The removed code was first mentioned in the patch referenced below,
    with the following description:
    ...
     * Some systems define the selinux context in the systemd Option for
       the /var/lib/xenstored tmpfs:
         Options=mode=755,context="system_u:object_r:xenstored_var_lib_t:s0"
       For the upstream version we remove that and let systems specify
       the context on their system /etc/default/xenstored or
       /etc/sysconfig/xenstored $XENSTORED_MOUNT_CTX variable
    ...
    It is nowhere stated (on xen-devel) what "Some systems" means, which
    is unfortunately common practice in nearly all opensource projects.
    http://lists.xenproject.org/archives/html/xen-devel/2014-03/msg02462.html
    
    Signed-off-by: Olaf Hering <olaf@aepfle.de>
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Cc: Wei Liu <wei.liu2@citrix.com>
    Cc: Anthony PERARD <anthony.perard@citrix.com>
    Cc: M A Young <m.a.young@durham.ac.uk>
    Cc: Luis R. Rodriguez <mcgrof@do-not-panic.com>
    Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    olafhering authored and konradwilk committed Jan 6, 2015
    Copy the full SHA
    a6b0435 View commit details
    Browse the repository at this point in the history
  14. libxl: Fix building libxlu_cfg_y.y with bison 3.0

    - Use %lex-param instead of obsolete YYLEX_PARAM to override lex scanner
      parameter
    - Change deprecated %name-prefix= to %name-prefix
    
    Tested against bison 2.4.1 and 3.0.2.
    
    This is expected to sometimes (depending on timestamps and whether the
    bison input files are edited) break building on systems with ancient
    versions of bison.  Bison 2.4.1 is known to work and was released in
    December 2008.
    
    Also, consquentially, regenerate bison output files with bison
    1:2.5.dfsg-2.1 from Debian wheezy.
    
    Signed-off-by: Ed Swierk <eswierk@skyportsystems.com>
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
    Tested-by: Wei Liu <wei.liu2@citrix.com>
    Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
    Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Ed Swierk authored and ijackson-citrix committed Jan 6, 2015
    Copy the full SHA
    7ba4cdf View commit details
    Browse the repository at this point in the history
  15. libxl: Renegerate flex output files

    Regenerate libxl_*_l.* with flex 2.5.35-10.1 as in current Debian
    wheezy.  The differences are trivial: addition of declarations of
    xlu__cfg_yyget_column and xlu__cfg_yyset_column, but no code body
    changes.
    
    Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
    Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    ijackson-citrix committed Jan 6, 2015
    Copy the full SHA
    3bd8559 View commit details
    Browse the repository at this point in the history
  16. EFI: suppress bogus loader warning

    This was accidentally lost in commit fbc3d9a ("EFI: add
    efi_arch_handle_cmdline() for processing commandline"), leading to the
    "Unknown command line option" warning being printed whenever options
    get passed to the core hypervisor or the Dom0 kernel.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    jbeulich authored and konradwilk committed Jan 6, 2015
    Copy the full SHA
    926e680 View commit details
    Browse the repository at this point in the history
  17. x86/HVM: prevent use-after-free when destroying a domain

    hvm_domain_relinquish_resources() can free certain domain resources
    which can still be accessed, e.g. by HVMOP_set_param, while the domain
    is being cleaned up.
    
    This is CVE-2015-0361 / XSA-116.
    
    Signed-off-by: Mihai Donțu <mdontu@bitdefender.com>
    Tested-by: Răzvan Cojocaru <rcojocaru@bitdefender.com>
    Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>
    mdontu-bd authored and ijackson-citrix committed Jan 6, 2015
    Copy the full SHA
    d3c151f View commit details
    Browse the repository at this point in the history
  18. reset PCI devices on force removal even when QEMU returns error

    On do_pci_remove when QEMU returns error, we just bail out early without
    resetting the device. On domain shutdown we are racing with QEMU exiting
    and most often QEMU closes the QMP connection before executing the
    requested command.
    
    In these cases if force=1, it makes sense to go ahead with rest of the
    PCI device removal, that includes resetting the device and calling
    xc_deassign_device. Otherwise we risk not resetting the device properly
    on domain shutdown.
    
    Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Stefano Stabellini authored and Ian Campbell committed Jan 6, 2015
    Copy the full SHA
    8233ca5 View commit details
    Browse the repository at this point in the history
  19. xen/arm: Initialize the domain vgic lock

    The domain vgic lock is used uninitialized.
    
    Signed-off-by: Julien Grall <julien.grall@linaro.org>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Julien Grall authored and Ian Campbell committed Jan 6, 2015
    Copy the full SHA
    876367b View commit details
    Browse the repository at this point in the history
  20. tools: libxl: link libxlu against libxl.

    It uses libxl_defbool_set and must therefore be linked against the
    right library.
    
    Spotted by dpkg-shlibdeps and pointed out by Bastian Blank:
    
    dpkg-shlibdeps: warning: symbol libxl_defbool_set used by debian/libxen-4.4/usr/lib/libxlutil-4.4.so found in none of the libraries
    
    This required switching the make rule from $^ to an explicit
    LIBXLU_OBJS since the former now includes libxenlight.so.
    
    Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
    Acked-by: Wei Liu <wei.liu2@citrix.com>
    Cc: Bastian Blank <waldi@debian.org>
    Ian Campbell committed Jan 6, 2015
    Copy the full SHA
    1ec4e33 View commit details
    Browse the repository at this point in the history
  21. xen: arm: correct off-by-one error in consider_modules

    By iterating up to <= mi->nr_mods we are running off the end of the boot
    modules, but more importantly it causes us to then skip the first FDT reserved
    region, meaning we might clobber it.
    
    Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
    Reviewed-by: Julien Grall <julien.grall@linaro.org>
    ijc authored and Ian Campbell committed Jan 6, 2015
    Copy the full SHA
    dea3ff6 View commit details
    Browse the repository at this point in the history
  22. tools/libxl: Use of init()/dispose() to avoid leaking libxl_dominfo.s…

    …sid_label
    
    libxl_dominfo contains a ssid_label pointer which will have memory allocated
    for it in libxl_domain_info() if the hypervisor has CONFIG_XSM compiled.
    However, the lack of appropriate use of libxl_dominfo_{init,dispose}() will
    cause the label string to be leaked, even in success cases.
    
    This was discovered by XenServers Coverity scanning, and are issues not
    identified by upstream Coverity Scan.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    CC: Ian Campbell <Ian.Campbell@citrix.com>
    CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
    CC: Wei Liu <wei.liu2@citrix.com>
    CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    andyhhp authored and Ian Campbell committed Jan 6, 2015
    Copy the full SHA
    54eb18c View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2015

  1. libxl: Fix if{} nesting in do_pci_remove

    do_pci_remove contained this:
    
        if (type == LIBXL_DOMAIN_TYPE_HVM) {
           [stuff]
        } else if (type != LIBXL_DOMAIN_TYPE_PV)
            abort();
        {
    
    This is bizarre, and not correct.  The effect is that HVM guests end
    up running both the proper code and that intended for PV guests.  This
    causes (amongst other things) trouble when PCI devices are
    hot-unplugged from HVM guests.
    
    This bug was introduced in abfb006 "tools/libxl: explicitly grant
    access to needed I/O-memory ranges".
    
    This is clear candidate for Xen 4.5, being a bugfix to an important
    feature.
    
    Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
    Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
    Tested-by: Robert Hu <robert.hu@intel.com>
    Rlease-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    CC: Sander Eikelenboom <linux@eikelenboom.it>
    CC: George Dunlap <George.Dunlap@eu.citrix.com>
    Ian Jackson authored and ijackson-citrix committed Jan 5, 2015
    Copy the full SHA
    7ca2558 View commit details
    Browse the repository at this point in the history
Older