Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add catalog_user.xml in msi #79

Merged
merged 2 commits into from Dec 9, 2018

Conversation

3 participants
@ctapmex
Copy link
Contributor

ctapmex commented Dec 9, 2018

В новой версии схем colorer появился обязательный файл catalog_user.xml. Добавляем его в инсталятор.

ctapmex added some commits Dec 9, 2018

@trexinc trexinc merged commit dc9a161 into FarGroup:master Dec 9, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yegor-mialyk

This comment has been minimized.

Copy link

yegor-mialyk commented Jan 16, 2019

Hi guys,

I do not think that adding catalog_user.xml in to the installer was the right approach. This config was created to separate user settings from global settings in order not to be overwritten during installation.

Now it is not the case and you lose your settings after the update.

Thanks,
Yegor

@ctapmex

This comment has been minimized.

Copy link
Contributor Author

ctapmex commented Jan 17, 2019

@ctapmex ctapmex deleted the ctapmex:fix-colorer-install branch Jan 17, 2019

ctapmex added a commit to ctapmex/FarManager that referenced this pull request Jan 18, 2019

trexinc added a commit that referenced this pull request Jan 19, 2019

Merge pull request #83 from ctapmex/revert-fix-colorer-install
Revert "Merge pull request #79 from ctapmex/fix-colorer-install"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.