Fix reading shared memory for Tuple
and Dict
spaces
#941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Soooo shared memory with
Tuple
orDict
spaces has been broken since the original implementation (5 years old).We didn't catch this as the expected tests should be
assert data_equivalence(read_samples, samples)
and were actually justdata_equivalence(...)
. (yes I have checked and can't find anymore instances of this bug in testing)As a result, the returned samples were roundtripped are
This PR fixes the bug