Skip to content

Update Windows wheels building to use newer boost version - #628

Merged
mwydmuch merged 7 commits into
masterfrom
mwydmuch/windows_workflow_update
Aug 10, 2025
Merged

Update Windows wheels building to use newer boost version#628
mwydmuch merged 7 commits into
masterfrom
mwydmuch/windows_workflow_update

Conversation

@mwydmuch

@mwydmuch mwydmuch commented Aug 9, 2025

Copy link
Copy Markdown
Member

No description provided.

@Trenza1ore

Trenza1ore commented Aug 9, 2025

Copy link
Copy Markdown
Member

Hiii @mwydmuch
Seems that previously 7-Zip 25.00 works well with boost but 25.01 in these newer build actions dislike the ../ paths for security reasons. Release notes mentioned a way to bypass:

Command line switch -snld20 can be used to bypass default security checks when creating symbolic links.

Source: https://github.com/ip7z/7zip/releases/tag/25.01

Some old discussions by author of 7-Zip on this topic:

"go to parent" links can be dangerous, because they can go to folder that is not expected by user that extracts archive to some specified folder.
And we want some safe isolation of extracted folders from another folders.
There are some possible complex attacks with multiple link files where each link points to parent level.
So we try to be more safe for link extracting.

Source: https://sourceforge.net/p/sevenzip/bugs/2436

Trenza1ore added a commit to Trenza1ore/ViZDoom-Contrib that referenced this pull request Aug 9, 2025
@Trenza1ore

Trenza1ore commented Aug 9, 2025

Copy link
Copy Markdown
Member

Actually, instead of mitigating this with an undocumented -snld20 switch (which requires upstream changes, also there is a chance 7-Zip 25.02 breaks it again, etc.), just using 25.00 as in previous Github actions (before Github updated 7zip on its Windows image a few days ago) is a better fix.

mwydmuch pushed a commit that referenced this pull request Aug 10, 2025
* Fix 7z version to 25.00 for installing boost

Fixes #628

* Use caching

* Update to use proper id for caching step

* Future-proofing: also cache 7zip choco path & use os name in cache key

* Use | for yml
@mwydmuch mwydmuch reopened this Aug 10, 2025
@mwydmuch

Copy link
Copy Markdown
Member Author

Thanks @Trenza1ore. Reopening this PR since the update of this action to v2 still makes sense in the case of a proper fix being deployed.

@Trenza1ore

Copy link
Copy Markdown
Member

Thanks @Trenza1ore. Reopening this PR since the update of this action to v2 still makes sense in the case of a proper fix being deployed.

Make sense, forgot that fixes also get pick up by Github like closes

@mwydmuch
mwydmuch force-pushed the mwydmuch/windows_workflow_update branch from 3ade68d to c0968ff Compare August 10, 2025 10:14
@mwydmuch mwydmuch changed the title Update Windows workflow Update Windows wheels building to use newer boost version Aug 10, 2025
@mwydmuch
mwydmuch merged commit d08b9a3 into master Aug 10, 2025
38 of 39 checks passed
@mwydmuch
mwydmuch deleted the mwydmuch/windows_workflow_update branch August 10, 2025 23:16
melnimr pushed a commit to melnimr/ViZDoom that referenced this pull request Aug 14, 2025
…-Foundation#629)

* Fix 7z version to 25.00 for installing boost

Fixes Farama-Foundation#628

* Use caching

* Update to use proper id for caching step

* Future-proofing: also cache 7zip choco path & use os name in cache key

* Use | for yml
melnimr pushed a commit to melnimr/ViZDoom that referenced this pull request Aug 14, 2025
…ndation#628)

Update Windows workflow and CMakeLists.txt to use boost v1.82.0 instead of 1.73.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants