New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pending tick #1024

Merged
merged 2 commits into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@LucasMonteiro1
Contributor

LucasMonteiro1 commented Nov 29, 2018

No description provided.

@sibelius

This comment has been minimized.

Collaborator

sibelius commented Nov 29, 2018

testing are failing

can you provide a test plan?

@LucasMonteiro1

This comment has been minimized.

Contributor

LucasMonteiro1 commented Nov 30, 2018

lint is failing by the jsx-a11y/accessible-emoji rule, but is working in the test.

screen

@sibelius

This comment has been minimized.

Collaborator

sibelius commented Nov 30, 2018

Can you fix the lint?

@LucasMonteiro1

This comment has been minimized.

Contributor

LucasMonteiro1 commented Nov 30, 2018

How to fix? I tried disabling the lint on the line and finding a replacement, but it did not work.

@sibelius

This comment has been minimized.

Collaborator

sibelius commented Dec 3, 2018

can you disable lint in this case?

@codecov

This comment has been minimized.

codecov bot commented Dec 3, 2018

Codecov Report

Merging #1024 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1024   +/-   ##
=======================================
  Coverage   42.97%   42.97%           
=======================================
  Files          20       20           
  Lines         498      498           
  Branches      108      108           
=======================================
  Hits          214      214           
  Misses        214      214           
  Partials       70       70
Impacted Files Coverage Δ
src/Bubble.js 46.15% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11548ed...0749692. Read the comment docs.

@sibelius sibelius merged commit e0fb667 into FaridSafi:master Dec 4, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 42.97% (+0%) compared to 11548ed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

PaperMonster added a commit to shobshop/react-native-gifted-chat that referenced this pull request Dec 7, 2018

Merge branch 'master' of https://github.com/FaridSafi/react-native-gi…
…fted-chat

* 'master' of https://github.com/FaridSafi/react-native-gifted-chat: (36 commits)
  Improve typings to allow for generic messages (FaridSafi#1025)
  pending tick (FaridSafi#1024)
  add send video support  (FaridSafi#1010)
  Show the username on the message (FaridSafi#929)
  Update README.md (FaridSafi#964)
  Update README.md (FaridSafi#996)
  Error in FlatList with latest react-native version
  fix imageStyle?: ViewStyle
  0.5.0
  Update index.d.ts
  Update index.d.ts
  Update index.d.ts
  Update index.d.ts
  Update README.md
  Improved typings (FaridSafi#940)
  Change component interface name ISystemChat to SystemChat (FaridSafi#995)
  Add prop to customise to Text style of timestamps (FaridSafi#942)
  Update README.md
  Update README.md
  Fix MessageContainer keyboard avoiding when messages array is empty (FaridSafi#898)
  ...

# Conflicts:
#	src/MessageContainer.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment