Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds AlignTop Property #1124

Merged
merged 2 commits into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@mattvv
Copy link
Contributor

mattvv commented Feb 5, 2019

Sometimes client's are fun!
My client demanded that the chat appeared at the top just like iMessage. This commit adds the option to do this.

Matt Van Veenendaal

@mattvv mattvv referenced this pull request Feb 7, 2019

Closed

Fix expo import #1123

Matt Van Veenendaal
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #1124 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1124   +/-   ##
=======================================
  Coverage   41.02%   41.02%           
=======================================
  Files          21       21           
  Lines         529      529           
  Branches      118      118           
=======================================
  Hits          217      217           
  Misses        236      236           
  Partials       76       76
Impacted Files Coverage Δ
src/GiftedChat.js 24.39% <ø> (ø) ⬆️
src/MessageContainer.js 20.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a408495...3be0255. Read the comment docs.

@mattvv

This comment has been minimized.

Copy link
Contributor Author

mattvv commented Feb 7, 2019

Updated this to satisfy the linter. Let me know if I need to do anything else. Would like to get this onto the main branchline so I can stop using my fork

@xcarpentier

This comment has been minimized.

Copy link
Collaborator

xcarpentier commented Feb 8, 2019

Hi,
Can you share a screenshot of it?
Thanks

@mattvv

This comment has been minimized.

Copy link
Contributor Author

mattvv commented Feb 8, 2019

Sure,
This is from my test app so ignore the crappy color scheme:
image

@xcarpentier

This comment has been minimized.

Copy link
Collaborator

xcarpentier commented Feb 8, 2019

Is that possible to add it screenshot on readme? In this PR. It's a nice. Maybe an new screenshots section...

@mattvv

This comment has been minimized.

Copy link
Contributor Author

mattvv commented Feb 8, 2019

I'm sorry mate, I don't have the time to set up a staged photo that looks nice for it :(

@xcarpentier

This comment has been minimized.

Copy link
Collaborator

xcarpentier commented Feb 8, 2019

screenshot 2019-02-08 at 18 18 00
This one is good, just to show alignment....

@xcarpentier xcarpentier merged commit 281902c into FaridSafi:master Feb 12, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 41.02% remains the same compared to a408495
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mattvv mattvv deleted the mattvv:alignTop branch Feb 20, 2019

@azzadrood

This comment has been minimized.

Copy link

azzadrood commented Feb 28, 2019

Is this published to npm? I see the props appear in readme but i try to use it and it is not working.

Using "react-native-gifted-chat": "^0.7.2"

@xcarpentier

This comment has been minimized.

Copy link
Collaborator

xcarpentier commented Feb 28, 2019

Not yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.